1395950 - Customize mode icons get placed incorrectly one spot to the left in the palette

Status: NEW

(Firefox :: Toolbars and Customization, defect, P4)

Description

[Erica Wright [:ewright]]

Attachment: customize-icons-shift.mp4

Dragging and dropping icons in customize mode.

when dropping the icon, it gets positioned one spot to the left of where it is actually being dropped.

Comment 1

[:Gijs (he/him)]

Does this only happen in the palette? Or also on toolbars / in the overflow panel?

Comment 2

[Erica Wright [:ewright]]

(In reply to :Gijs (queue backed up, slow) from comment #1)
> Does this only happen in the palette? Or also on toolbars / in the overflow
> panel?

It only happens in the palette.

Comment 3

[Alice0775 White]

I think this is not a regression.
I can reproduce this problem with Firefox 29. It has been since Australis Marge.
(Prior to Australis, the dropped icon is always at the very end regardless of the drop position)

Comment 4

[:Gijs (he/him)]

(In reply to Alice0775 White from comment #3)
> I think this is not a regression.
> I can reproduce this problem with Firefox 29. It has been since Australis
> Marge.
> (Prior to Australis, the dropped icon is always at the very end regardless
> of the drop position)

Indeed, this is true for trying to drop items at the end, but not for putting items in the middle. The animation and placement there broke at some point, I think. I'm not clear on why that happened, but it's probably one of my patches.

Comment 5

[:Gijs (he/him)]

The animation etc. in general got fixed in bug 1415056. However, the specific case of items at the bottom + end of the list is harder to fix. I looked into this for a while and gave up, given that it's likely we'll rearchitect the whole lot of this in bug 1388154. So clearing ni.

Comment 6

[Firefox Bug Husbandry Bot]

https://wiki.mozilla.org/Bug_Triage/Projects/Bug_Handling/Bug_Husbandry#Move_fix-optionals