1396992 - Save Page As... should be disabled for preferences, new tab, and add-ons (all about: pages ?)

Status: NEW

(Firefox :: Menus, enhancement, P3)

Description

[Asa Dotzler [:asa]]

The main menu lets you save these about pages but that's not a useful feature. The menu item should be disabled for about: pages or at least the main ones.

Comment 1

[Jared Wein [:jaws] (please needinfo? me)]

Attachment: Bug 1396992 - Disable the save page command when on secure internal pages.

Review commit: https://reviewboard.mozilla.org/r/195546/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/195546/

Comment 2

[Jared Wein [:jaws] (please needinfo? me)]

The patch I'm attaching fixes this (not for about:newtab because we don't show that page as a secure-internal page). It shims this in through where we update the page identity UI which might not be the best place but it limits it to the only place where we make that distinction right now.

Comment 3

[Drew Willcoxon :adw]

Comment on attachment 8924301 [details]
Bug 1396992 - Disable the save page command when on secure internal pages.

https://reviewboard.mozilla.org/r/195546/#review200776

The implementation lgtm.  Is there a context for this change though?  If Save's not useful on these pages, then Email Link, Print, Text Encoding, and Page Info aren't either I would think...  I'm not really suggesting that we disable them too, but this bug seems kind of arbitrary to me, separate from a context of how the browser UI should change on these pages.

Comment 4

[Sylvestre Ledru [:Sylvestre]]

Moving to p3 because no activity for at least 24 weeks.