1397119 - Move GetBStartBCBorderWidth, GetBEndBCBorderWidth and any similar methods' return type to BCPixelSize rather than nscoord

Status: RESOLVED FIXED

(Core :: Layout: Tables, enhancement, P3)

Description

[Ya-Chieh Wu (inactive)]

Per Bug Comment 21 mentioned, 

we should change these methods on nsTableRowFrame:
  nscoord GetBStartBCBorderWidth() const { return mBStartBorderWidth; }
  nscoord GetBEndBCBorderWidth() const { return mBEndBorderWidth; }
and any similar methods (like the two on nsTableColFrame) return BCPixelSize
rather than nscoord.

Comment 1

[Ya-Chieh Wu (inactive)]

s/Per Bug Comment 21/Per Bug 895096 Comment 21

Comment 2

[Chris Peterson [:cpeterson]]

Attachment: Bug 1397119 - Part 1: Change nsTable*Frame::Get*BorderWidth() return values from nscoord to BCPixelSize. r?dbaron

Comment 3

[Chris Peterson [:cpeterson]]

Attachment: Bug 1397119 - Part 2: Rename p2t to d2a (app units per device pixel). r?dbaron

Bug 895096 comment 0 recommends using the name `d2a` instead of `p2t`.

Depends on D5368

Comment 4

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Comment on attachment 9007488 [details]
Bug 1397119 - Part 1: Change nsTable*Frame::Get*BorderWidth() return values from nscoord to BCPixelSize. r?dbaron

David Baron :dbaron: 🏴󠁵󠁳󠁣󠁡󠁿 ⌚UTC-7 has approved the revision.

Comment 5

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Comment on attachment 9007489 [details]
Bug 1397119 - Part 2: Rename p2t to d2a (app units per device pixel). r?dbaron

David Baron :dbaron: 🏴󠁵󠁳󠁣󠁡󠁿 ⌚UTC-7 has approved the revision.

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/6d0f8348cdb6
Part 1: Change nsTable*Frame::Get*BorderWidth() return values from nscoord to BCPixelSize. r=dbaron

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/c8c95278f139
Part 2: Rename p2t to d2a (app units per device pixel). r=dbaron

Comment 8

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/6d0f8348cdb6
https://hg.mozilla.org/mozilla-central/rev/c8c95278f139