Closed
Bug 1397930
Opened 7 years ago
Closed 7 years ago
Official builds of Fennec need to use the same Safe Browsing client ID as desktop
Categories
(Toolkit :: Safe Browsing, enhancement, P2)
Toolkit
Safe Browsing
Tracking
()
RESOLVED
FIXED
mozilla57
Tracking | Status | |
---|---|---|
firefox57 | --- | fixed |
People
(Reporter: francois, Assigned: francois)
References
Details
(Whiteboard: #sbv4-m10)
Attachments
(1 file)
On Desktop, official builds use navclient-auto-ffox as a Safe Browsing client ID: https://searchfox.org/mozilla-central/rev/44c693914255638d74bcf1ec3b0bcd448dfab2fd/modules/libpref/init/all.js#5415-5421 On Fennec, however, it's set to "Firefox": https://searchfox.org/mozilla-central/rev/44c693914255638d74bcf1ec3b0bcd448dfab2fd/mobile/android/app/mobile.js#647 https://searchfox.org/mozilla-central/rev/44c693914255638d74bcf1ec3b0bcd448dfab2fd/mobile/android/confvars.sh#10 We should make all official builds use the "official" client ID of "navclient-auto-ffox" and maybe non-official builds should use @MOZ_APP_UA_NAME@ if it's also set on desktop.
Comment hidden (mozreview-request) |
Assignee | ||
Comment 2•7 years ago
|
||
(In reply to François Marier [:francois] from comment #0) > maybe non-official builds should use > @MOZ_APP_UA_NAME@ if it's also set on desktop. Can't use that variable on Desktop, it doesn't appear to be defined. However, we can use %NAME% which is normally defined as "Firefox". The advantage of doing this is that we'll be able to tell things rebrands of Firefox apart in server-side error logs.
Assignee | ||
Updated•7 years ago
|
Summary: Official builds of Fennec needs to use the same Safe Browsing client ID as desktop → Official builds of Fennec need to use the same Safe Browsing client ID as desktop
Comment 3•7 years ago
|
||
mozreview-review |
Comment on attachment 8905734 [details] Bug 1397930 - Use the same Safe Browsing client ID on all official builds. https://reviewboard.mozilla.org/r/177538/#review184338 Maybe mention it to the Google guys if you still talk to them regularly. Doubt they'll notice much, though.
Attachment #8905734 -
Flags: review?(gpascutto) → review+
Pushed by fmarier@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/956163f1fa0e Use the same Safe Browsing client ID on all official builds. r=gcp
Assignee | ||
Comment 5•7 years ago
|
||
(In reply to Gian-Carlo Pascutto [:gcp] from comment #3) > Maybe mention it to the Google guys if you still talk to them regularly. Will do, thanks.
Comment 6•7 years ago
|
||
Backed out on request from francois: https://hg.mozilla.org/integration/autoland/rev/08b377af73bba67a528167bdf68f3857b1b41491
Comment hidden (mozreview-request) |
Assignee | ||
Comment 8•7 years ago
|
||
Can you please review this simpler patch? Google asked us to treat all forks the same ("Firefox").
Flags: needinfo?(gpascutto)
Comment 9•7 years ago
|
||
mozreview-review |
Comment on attachment 8905734 [details] Bug 1397930 - Use the same Safe Browsing client ID on all official builds. https://reviewboard.mozilla.org/r/177538/#review184678
Comment 11•7 years ago
|
||
Pushed by fmarier@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/cfd5924a10e3 Use the same Safe Browsing client ID on all official builds. r=gcp
Comment 12•7 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/cfd5924a10e3
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
status-firefox57:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla57
You need to log in
before you can comment on or make changes to this bug.
Description
•