Closed Bug 1398103 Opened 7 years ago Closed 7 years ago

Distance between buttons are not the same as in the spec (Compact Density)

Categories

(Firefox :: Theme, defect, P1)

Product:
Firefox
Component:
Theme
Version:
57 Branch
Platform:
Unspecified
All
Type:
defect

Tracking

()

Status:
VERIFIED FIXED
Milestone:
Firefox 58
Tracking Flags:
Tracking Status
firefox57 --- wontfix
firefox58 --- verified

People

(Reporter: valentina.ona, Assigned: dao)

References

(Blocks 2 open bugs)

Details

(Whiteboard: [reserve-photon-visual])

Attachments

(2 files, 1 obsolete file)

toolbar.bmp
317.47 KB, image/bmp
Details
Bug 1398103 - Adjust toolbar and toolbar button spacing to match photon spec.
59 bytes, text/x-review-board-request
daleharvey
: review+
Details
Attached image toolbar.bmp — 
Mozilla/5.0 (Windows NT 6.3; WOW64; rv:57.0) Gecko/20100101 Firefox/57.0
Build ID:  20170907100318

[Affected versions]:
Nightly 57.0a1

[Affected platforms]:
Windows 8.1 x 64

[Steps to reproduce]:
1. Open Nightly 57.0a1
2. Go to www.mozilla.org
3. Open the Customize menu.
4. Set the Density as Compact. 
5. Please verify if the dimensions presented in the specifications are respected. 
Verify the distance between Back, Forward, Reload, Start Page, etc. buttons from the browser Toolbar.

[Expected Results]:
The distance between buttons from the browser Toolbar should be 2 px. 

[Actual Results]:
 The distance between buttons from the browser Toolbar is 5px.

[Note]: Please take a look on the attachment.
Also reproducible on Mac OSX 10.12.5
Flags: needinfo?(shorlander)
This is also reproducible on Windows 10: the distance between the button is 4px instead of 2px for Compact density
OS: Windows 8.1 → All
Priority: -- → P5
Flags: qe-verify?
Whiteboard: [photon-visual] [triage] → [reserve-photon-visual]
Flags: needinfo?(shorlander)
Flags: qe-verify? → qe-verify+
Blocks: photon-visual
Assignee: nobody → dao+bmo
Status: NEW → ASSIGNED
status-firefox57: affected → wontfix
Priority: P5 → P1
Blocks: 1392978
Attachment #8922795 - Attachment is obsolete: true
Attachment #8922795 - Flags: review?(dharvey)
Attachment #8922799 - Attachment is obsolete: true
Attachment #8922799 - Flags: review?(dharvey)
Blocks: 1399025
Blocks: 1399138
Comment on attachment 8922795 [details]
Bug 1398103 - Adjust toolbar and toolbar button spacing to match photon spec.

https://reviewboard.mozilla.org/r/193948/#review199604

Nice to get rid of an !important, and works good here, cheers
Attachment #8922795 - Flags: review?(dharvey) → review+
Pushed by dgottwald@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/afc2cbb9370f
Adjust toolbar and toolbar button spacing to match photon spec. r=daleharvey
Backed out changeset afc2cbb9370f (bug 1398103) for unexpected network connection in wpt2 /css/css-tables-3/table-model-fixup-2.html r=backout on CLOSED TREE 
https://treeherder.mozilla.org/#/jobs?repo=autoland&revision=afc2cbb9370f0d83bd5e64ea2477f917b0339926&selectedJob=140999279
https://hg.mozilla.org/integration/autoland/rev/c99501471321aa32047b23a26734212e1ceae4cc
Flags: needinfo?(dao+bmo)
Pushed by dgottwald@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/8591a7392381
Adjust toolbar and toolbar button spacing to match photon spec. r=daleharvey
https://hg.mozilla.org/mozilla-central/rev/8591a7392381
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
status-firefox58: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 58
I verified this issue using Nightly 58.0a1 with Build ID 20171102222620 on Windows 10 x64, Windows 8.1 x32 and Mac OS X 10.13. 
I will mark this as verified fixed.
status-firefox58: fixed → verified
Status: RESOLVED → VERIFIED
Regressions: 1595772
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: