1398329 - convert uses of "defer" to "new Promise" in client/shared (except in test/, vendor/ and widgets/ subdirs)

Status: RESOLVED FIXED

(DevTools :: Shared Components, enhancement, P3)

Description

[tera_1225]

User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.12; rv:57.0) Gecko/20100101 Firefox/57.0
Build ID: 20170907220212

Comment 1

[tera_1225]

As a segment of https://bugzilla.mozilla.org/show_bug.cgi?id=1283869
File list:
$ grep -R "defer()" . | grep -v "/test/" | grep -v "/vendor/" | grep -v "/widgets" | sed s/:.*// | uniq
./AppCacheUtils.jsm
./developer-toolbar.js
./doorhanger.js
./frame-script-utils.js
./getjson.js
./poller.js
./redux/middleware/promise.js

There are quite a few in there so I thought it best to leave /test/ /vendor/ and /widgets/ for a later bug.

Comment 2

[tera_1225]

Attachment: Proposed patch

Comment 3

[Jan Honza Odvarko [:Honza] (always need-info? me)]

Comment on attachment 8906138 [details] [diff] [review]
Proposed patch

Review of attachment 8906138 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks for the patch, looks good to me!

R+ assuming my comment is resolved and try is green!

Try push:
https://treeherder.mozilla.org/#/jobs?repo=try&revision=5d82b099c6e3327b1983d65e623ccd95b86cd5dc

Honza

::: devtools/client/shared/AppCacheUtils.jsm
@@ +35,3 @@
>  var { gDevTools } = require("devtools/client/framework/devtools");
>  var Services = require("Services");
>  var promise = require("promise");

`promise` is never used, can be removed.

Comment 4

[tera_1225]

Attachment: Address issue raised by [:Honza] about previous patch, and extra lines caught by ES linter.

I'm sorry this is in a separate patch... Couldn't quite get on top of combining it into the previous patch (I'm new to mercurial).

Comment 5

[Jan Honza Odvarko [:Honza] (always need-info? me)]

Comment on attachment 8907302 [details] [diff] [review]
Address issue raised by [:Honza] about previous patch, and extra lines caught by ES linter.

Review of attachment 8907302 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks for the update!

Honza

Comment 6

[Jan Honza Odvarko [:Honza] (always need-info? me)]

Please push to try yet before landing

Honza

Comment 7

[tera_1225]

Hi Jan. Glad everything is ok for you. Can you possible perform the push to TRY for me as I don't have access myself...

Comment 8

[tera_1225]

Hi Honza, even (sorry...)

Comment 9

[tera_1225]

Attachment: Another fix for errors caught by ES lint: a missing empty line at end of file, and logic error causing promise chain rejection.

Comment 10

[Jan Honza Odvarko [:Honza] (always need-info? me)]

Comment on attachment 8907853 [details] [diff] [review]
Another fix for errors caught by ES lint: a missing empty line at end of file, and logic error causing promise chain rejection.

Review of attachment 8907853 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks for the update!

Honza

Comment 11

[tera_1225]

Attachment: Bug1398329-4.patch

Woops, wrong file... in last attachment 8907853 [details] [diff] [review]

Comment 12

[tera_1225]

Seems like the tests are ok, aside from a few that are intermittent failures that already have bugs.
https://treeherder.mozilla.org/#/jobs?repo=try&revision=644bf92233d13d2378aecdc5a5629e9d695772db&selectedJob=131105247

Comment 13

[Nicolas Chevobbe [:nchevobbe]]

Comment on attachment 8908192 [details] [diff] [review]
Bug1398329-4.patch

Review of attachment 8908192 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good to me. Thanks !

Comment 14

[Ryan VanderMeulen [:RyanVM]]

In the future, please fold your follow-up patches into the main patch before requesting checkin.

Comment 15

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/e5d3009b7d0a
Convert uses of defer to new Promise in client/shared (except in test/, vendor/ and widgets/ subdirs). r=Honza, r=nchevobbe

Comment 16

[tera_1225]

[:RyanVM] Sorry about the multiple patches... I'm new to mercurial and trying to get the hang of the patch system. Have been setting up MozReview also so should be less trouble in the future.
Thanks for the checkin.
Regards,
Mark.

Comment 17

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/e5d3009b7d0a