139833 - On a localized build, unable to copy mails to Sent folder when sending out from a POP account after selecting the account that holds the Sent folder

Status: VERIFIED FIXED

(MailNews Core :: Internationalization, defect)

Description

[ji]

Build: 04/19 Ja build.

This is a very strange problem. 
On above Ja build, default mail folder names are translated to Japanese. So on
account manager-> Copies and Folders pane. Sent folder is also translated. With
this, everytime when I send out mails from a POP account, I get an error msg
saying that it can't copy mails to Sent folder. And I don't have this problem
when connecting to the server the 1st time. But after exiting the program and
reconnecting the server the 2nd time, I start to have this problem. When I get
this error msg, I can see on the folder pane there is an extra folder generated
with another set of default folders as its children folders. 

Steps to reproduce:
1. Create a new profile with the Ja build.
2. Set up a POP mail account with the new profile.
3. After login window comes up, login with correct passwd,  send out a mail, so
far, no problem.
4. Exit the program, restart, and bring up Mail window.
5. After connecting to the server, compose a mail and click on Send
   Then an error msg comes up, saying that the mail is sent successfully, but it
can't copy mail to the Sent folder. Observe the folder pane, there is extra
folder created, the parent folder name is blank, but with another set of default
folders as its child folders. I'll attach a screenshot.
6. Open Edit | Mail and News Account Settings | Copies and Folders pane, change
the folder which holds sent copies to a different one, then I can sent out mail.
7. Open Explorer, go to the profile -> Mail folder, besides "Local Folders" and
POP mail account, there is extra msf file generated.

Comment 1

[ji]

Attachment: A screenshot.

Comment 2

[ji]

Nominating for nsbeta1, since the user will get this error message when sending
out mails if he/she doesn't change the sent folder location, and also the extra
folder displayed on the folder pane is very confusing.

Comment 3

[nhottanscp]

Cc to putterman.
Scott, I would like someone in your group to work on this. I think localizable
folder name for Pop is a new feature. Who implement that?

Comment 4

[Navin Gupta]

taking

Comment 5

[marina]

i hit the same problem yesterday with the POP account on the new ja build (based
on 04-19 branch)

Comment 6

[Navin Gupta]

Are you using Quick launch/turbo, curious because it is happening on 2nd time

Comment 7

[ji]

No, I installed the build with turbo turned off.

Comment 8

[ji]

Attachment: A screenshot of Copies and Folders pane of account manager

Additional info:
On Copies and Folders pane, for sent folder selection, if I choose "Others" and
select localized Sent folder from there, it can copy the mail to Sent folder.
So it looks like it can't map the localized Sent folder name from the localized
string, which is the list box label of the first option for Sent folder
location, to the English mailbox name.

The reason that it didn't fail the 1st time could be that it didn't go through
this path: getting Sent folder name from the localized list box label and
mapping to English foldername which is really generated in the profile.

Comment 9

[Navin Gupta]

what does your user_pref mail.identity.id1.fcc_folder look like in prefs.js? It
should be something like "mailbox://3qatest03@nsmail-2/Sent"

Comment 10

[Frank Tang]

impact language users- all European and Asian internet users who use mail. (329M
users or 51.8% of total internet users)
Visibility- HIGH- major functionality
Recover after hitting the problem- 
Work around- set the copy folder manually inside the account setup.

this is a [adt1] bug, all the users using POP3 mail on localized build will see
this issue several times a day. 

Comment 11

[ji]

Attachment: my prefs.js file.

Comment 12

[ji]

Save as Draft or Template has the same problem.

Comment 13

[Navin Gupta]

yes, your prefs are messed up 

user_pref("mail.identity.id1.fcc_folder", "mailbox://[e-mail]/áÈì¤");

should be 

user_pref("mail.identity.id1.fcc_folder", "mailbox://[e-mail]/Sent");

So when you send mail first time ? can you verify what this prefs looks like. 
I may need a localized debug build to debug this.

Comment 14

[Ying-Lin Xia]

You can use your US debug build, plus the JA language pack.
ftp://sweetlou/products/client/l10n_dev/seamonkey/ja/win/2002-04-19-08-1.0.0/xp
i/

Comment 15

[ji]

I played more with the build, it looks like it has nothing to do with the passwd
dialog.
And it has nothing to do with when it's connected to the server either. To
reproduce the problem, you just need to go to Copies and Folders pane, reselect
the account following the translated list box label which contains translated
Sent folder name.
It also happens when you change the account to Local Folders on the list. It
seems selecting the account writes the translated folder name to the pref.

Comment 16

[Navin Gupta]

Attachment: proposed fix

The fix is to use the internal names and not the prettyName when we are again
writing the Sent, Drafts.. folder settings as prefs. We always use internal
names
for folderURIs, prettyName is just used for display.

Comment 17

[Navin Gupta]

ji, thanks for looking into what was causing the bug. This affects all builds.
although on US builds we are able to create a new sent folder because uri is
(ascii -utf8 format) but for localized builds it becomes a problem. 

bhuvan, can I get an r=? thx.

Comment 18

[(not reading, please use [e-mail] instead)]

I think gMessengerBundle is now unused.  Can you confirm, and if so, remove it 
from the js and xul (I think you can remove the "bundle_messenger" element)

 

Comment 19

[racham]

Comment on attachment 81176 [details] [diff] [review]
proposed fix

yeah, removed unused vars. please do make sure that it is not being used in any
other places via some looped dependency.

r=bhuvan

Comment 20

[Navin Gupta]

Attachment: patch removing unused global vars.

Comment 21

[Navin Gupta]

Comment on attachment 81209 [details] [diff] [review]
patch removing unused global vars. 

carrying fwd bhuvan's 
review

Comment 22

[(not reading, please use [e-mail] instead)]

Comment on attachment 81209 [details] [diff] [review]
patch removing unused global vars. 

sr=sspitzer

but make extra sure that your changes don't cause any problems, mozilla or ns. 
the change to AccountWizard.xul, especially.

Comment 23

[racham]

Can you not checkin the AccountWizard changes now (I will file a new bug to
remove all unused vars in mailnews) ? We have bunch of overlays, which rely on
this file from ns side. We don't want any unexpected regressions from there at
this point of time. I only meant that you should take them out of am-copies.xul
 as that looks pretty self-contained. Don't need a new patch, just get
am-copies.* changes in.

Comment 24

[Navin Gupta]

checked in am-copies.js and am-copies.xul changed on trunk. 

Comment 25

[scottputterman]

Can someone try this fix out on the trunk?  Navin, what else needs to be tested
because of this fix?

Comment 26

[Navin Gupta]

The changes affect only copies and folders panel in account manager. 

Comment 27

[scottputterman]

Adding adt1.0.0+.  Please check this into the branch as soon as possible after
getting drivers approval and add the fixed1.0.0 keyword.

Comment 28

[ji]

Ying or Ray, how can I replace am-copies.js and am-copies.xul in ja build with
those checked in by Navin so i can verify the fix before the next ja build?
Or what should I do on an English trunk build to get a pseudo localized account
manager | copies and folders pane?

Comment 29

[Randell Jesup [:jesup] (needinfo me)]

Comment on attachment 81209 [details] [diff] [review]
patch removing unused global vars. 

a=[e-mail] for branch checkin

Comment 30

[ji]

Verfied as fixed on a ja build with the new messenger.jar that contains Navin's
am-copies.js and am-copies.xul. Thanks Ying for the help.

Comment 31

[ji]

Verified as fixed with Ja build.