Closed Bug 1398578 Opened 7 years ago Closed 1 year ago

Investigate if there is anything to optimize in IonSetPropertyIC or in its usage

Categories

(Core :: JavaScript Engine: JIT, defect, P3)

defect

Tracking

()

RESOLVED INVALID
Tracking Status
firefox57 --- affected

People

(Reporter: smaug, Unassigned)

References

(Blocks 1 open bug)

Details

Since bug 1388388 we should attach a stub to call SetObjectElement directly instead of going through IonSetPropertyIC::update. It's not clear from the profile why that's not working here.
Blocks: 1245279
Flags: needinfo?(jdemooij)
Priority: -- → P3
It looks like this is an object with many properties so we convert it to dictionary mode. The IC does not handle new dictionary properties so we disable it.

In tryAttachAddSlotStub, we could add an IC stub that guards the object is inDictionaryMode and then we can just call SetObjectElement...

Also the profile reveals a bunch more silly perf bugs on the SetProperty path that I wasn't aware of yet. Will fix.
Flags: needinfo?(jdemooij)
Depends on: 1401577
Severity: normal → S3

We've done a bunch of work here over the years, so I'll close this bug since it doesn't have any specific remaining clues

Status: NEW → RESOLVED
Closed: 1 year ago
Resolution: --- → INVALID
You need to log in before you can comment on or make changes to this bug.