Closed Bug 1399277 Opened 7 years ago Closed 7 years ago

/firstrun page for developer edition

Categories

(www.mozilla.org :: Pages & Content, enhancement)

Product:
www.mozilla.org
Component:
Pages & Content
Version:
Production
Type:
enhancement
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED

People

(Reporter: erenaud, Unassigned)

References

(
URL
)

Details

Attachments

(3 files)

Screen Shot 2017-09-21 at 16.42.42.png
73.90 KB, image/png
Details
Link to GitHub pull-request: https://github.com/mozilla/bedrock/pull/5129
44 bytes, text/x-github-pull-request
Details | Review
Link to GitHub pull-request: https://github.com/mozilla/bedrock/pull/5202
44 bytes, text/x-github-pull-request
Details | Review 
Apply new design and copy, provided by TL&I team, to the /firstrun developer edition page

Go live is 9/26
Dear team, please find the final design and copy assets here:
https://drive.google.com/drive/folders/0B1WOZUXv8dZuUVR3dWxmY0tXMlU?usp=sharing

Note that the Firefox DevEdition logo is not final, we will share the asset by 9/15
Final Fx DevEdition logo is ready and available in the project folder:
https://drive.google.com/drive/folders/0B1WOZUXv8dZuZUNxTG1zVTQ0TlE?usp=sharing
Schalk - this page is probably 90% reuse of the Dev Edition landing page content/design that Craig is working on now.  Please be sure to consult with him when picking up this work.  Target go live is 9/26
Flags: needinfo?(schalk.neethling.bugs)
(In reply to Eric Renaud from comment #3)
> Schalk - this page is probably 90% reuse of the Dev Edition landing page
> content/design that Craig is working on now.  Please be sure to consult with
> him when picking up this work.  Target go live is 9/26

Gotcha, thanks Eric.
Assignee: nobody → schalk.neethling.bugs
Flags: needinfo?(schalk.neethling.bugs)
The color of the icons as well as their circular border does not match the color color-mozblue(#0c99d5) we use on bedrock. Not sure if I should make a special case here or, whether the color of the icons needs to be updated.

Thoughts?
Flags: needinfo?(erenaud)
(In reply to Schalk Neethling [:espressive] from comment #5)
> Created attachment 8910759 [details]
> Screen Shot 2017-09-21 at 16.42.42.png
> 
> The color of the icons as well as their circular border does not match the
> color color-mozblue(#0c99d5) we use on bedrock. Not sure if I should make a
> special case here or, whether the color of the icons needs to be updated.
> 
> Thoughts?

No worries, spoke to Alex and he stated that mozblue is a left over artifact so, will change the color to match the icons.
Flags: needinfo?(erenaud)
(In reply to Maciej Pluta from comment #2)
> Final Fx DevEdition logo is ready and available in the project folder:
> https://drive.google.com/drive/folders/
> 0B1WOZUXv8dZuZUNxTG1zVTQ0TlE?usp=sharing

Hey there, I need the Nightly logo in a high-res format or even SVG for the firstrun and what's new pages. Thanks!
Hey Schalk, the logo asset is located here:
https://drive.google.com/open?id=0B1WOZUXv8dZuZ0RaQU1fcFo3WFk
(In reply to Maciej Pluta from comment #8)
> Hey Schalk, the logo asset is located here:
> https://drive.google.com/open?id=0B1WOZUXv8dZuZ0RaQU1fcFo3WFk

That is the dev edition logo no? For firstrun and what's new I need the Nightly logo. Thanks
Hey Schalk, I'm sorry, you're right. I don't have the SVG file at hand. Can the asset be picked up from this site?  https://www.mozilla.org/en-US/firefox/channel/desktop/ I don't think it's an SVG either, but maybe it will work for the meantime?
(In reply to Maciej Pluta from comment #10)
> Hey Schalk, I'm sorry, you're right. I don't have the SVG file at hand. Can
> the asset be picked up from this site? 
> https://www.mozilla.org/en-US/firefox/channel/desktop/ I don't think it's an
> SVG either, but maybe it will work for the meantime?

That will totally work. Thanks!
@Eric, would this impact l10n at all?
The launch of the page is tomorrow, and just realize from the PR that l10n is part of the scope.
Flags: needinfo?(erenaud)
Peiying - per the email i sent earlier today - Stephan has already localized the DE content.  en-US and DE are the locales required for launch. l10n needs to be open to all other locales, but is not required for launch, per Porfirio.
Flags: needinfo?(erenaud) → needinfo?(pmo)
Commits pushed to master at https://github.com/mozilla/bedrock

https://github.com/mozilla/bedrock/commit/12b5eff066a05faa7e7203acd91f424645b56f5e
Fix Bug 1399277, quantum dev edition firstrun page implementation

https://github.com/mozilla/bedrock/commit/e12a25c07b0852be87ad4d179f37c9aab899f7e7
Merge pull request #5129 from schalkneethling/bug1399277-dev-edition-firstrun

Fix Bug 1399277, quantum dev edition firstrun page implementation
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
This is being pushed for localization.
Team,

Thank you again for launching the sites. We have idinetified a few small things we'd like to be changed post-launch:
https://docs.google.com/a/mozilla.com/document/d/1OboHPRVEKOgbyEbEzWWg5zMBSCBg8QJIPPTI_Nsmfo8/edit?usp=sharing
Flags: needinfo?(erenaud)
(In reply to Maciej Pluta from comment #20)
> Team,
> 
> Thank you again for launching the sites. We have idinetified a few small
> things we'd like to be changed post-launch:
> https://docs.google.com/a/mozilla.com/document/d/
> 1OboHPRVEKOgbyEbEzWWg5zMBSCBg8QJIPPTI_Nsmfo8/edit?usp=sharing

For everything except the image links, these can potentially all have a l10n impact so, I am going to NI :CoCoMo to get her input.

With regards to "We would like these tools to be linked to MDN - as they were in the previous version of the site"

If we have the links on the images, or the title, we can avoid l10n problems here. If however, we want to add something like "Learn more" that links to MDN, it can potentially be problematic.

--

Therefore I am suggesting that we keep it consistent and link the images as is requested for JavaScript Debugger on GitHub
and the CSS Grid Playground links. Thoughts?

--

Peiying, specifically for this change request:

Change “built with React and Ember” to "Built on React and Redux"

There was a PR that I reviewed and merged that was essentially the same aka https://github.com/mozilla/bedrock/pull/5174/files#diff-231ed733effdb62461ebde9d32be6983R77

When I make this change on /firstrun and /whatsnew should I use the same l10n tag[{% if l10n_has_tag('ember_reference_fix') %}] for these or a different one?
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Schalk, I have not processed this update yet, so you can use the same tag for the update.  Let me know once this is done. You can indicate it in the PR.
Flags: needinfo?(pmo)
(In reply to Peiying Mo [:CocoMo] from comment #22)
> Schalk, I have not processed this update yet, so you can use the same tag
> for the update.  Let me know once this is done. You can indicate it in the
> PR.

Thanks!
From this document:
https://docs.google.com/document/d/1OboHPRVEKOgbyEbEzWWg5zMBSCBg8QJIPPTI_Nsmfo8/edit?ts=59de72bf

It sounds like the intent is to use the link copy and link destinations from here https://www.mozilla.org/en-US/firefox/56.0a2/firstrun/ for the links added the to the new /firstrun and /whatsnew pages

Peiying, my first question is then, as those strings do currently exist translated (I am making an assumption here), what is the l10n impact of adding them to these new pages? If they do not exist, of course there is a bigger issue. Thoughts?


Maciej, do we want to make these same updates to the firefix/developer page or only /firstrun and /whatsnew
Flags: needinfo?(pmo)
Flags: needinfo?(mpluta)
> Peiying, my first question is then, as those strings do currently exist
> translated (I am making an assumption here), what is the l10n impact of
> adding them to these new pages? If they do not exist, of course there is a
> bigger issue. Thoughts?

I was extracting strings from this PR yesterday, we have not released them yet. If you can add them with l10n tags, we can include them in this week's handoff to the communities.
Flags: needinfo?(pmo)
Of course, if it takes more time, we can include them in next week's handoff.
(In reply to Schalk Neethling [:espressive] from comment #24)
> From this document:
> https://docs.google.com/document/d/
> 1OboHPRVEKOgbyEbEzWWg5zMBSCBg8QJIPPTI_Nsmfo8/edit?ts=59de72bf
> 
> It sounds like the intent is to use the link copy and link destinations from
> here https://www.mozilla.org/en-US/firefox/56.0a2/firstrun/ for the links
> added the to the new /firstrun and /whatsnew pages
> 
> Peiying, my first question is then, as those strings do currently exist
> translated (I am making an assumption here), what is the l10n impact of
> adding them to these new pages? If they do not exist, of course there is a
> bigger issue. Thoughts?
> 
> 
> Maciej, do we want to make these same updates to the firefix/developer page
> or only /firstrun and /whatsnew

Hey Schalk, thank you for checking. We only wanted to make these changes to /firstrun and /whatsnew, NOT the firefox/developer (as we want the user to stay on this page and keep the focus on Fx download) .
Flags: needinfo?(mpluta)
As mentioned in https://docs.google.com/document/d/1OboHPRVEKOgbyEbEzWWg5zMBSCBg8QJIPPTI_Nsmfo8/edit?ts=59df918a

"I just want to make sure everyone understand this means, if a locale has not been localised, there is no fallback i.e. Links will show for localised content, no links for those that have not. alainez@mozilla.com Does that work for you?"
Flags: needinfo?(alainez)
(In reply to Maciej Pluta from comment #27)
> (In reply to Schalk Neethling [:espressive] from comment #24)
> > From this document:
> > https://docs.google.com/document/d/
> > 1OboHPRVEKOgbyEbEzWWg5zMBSCBg8QJIPPTI_Nsmfo8/edit?ts=59de72bf
> > 
> > It sounds like the intent is to use the link copy and link destinations from
> > here https://www.mozilla.org/en-US/firefox/56.0a2/firstrun/ for the links
> > added the to the new /firstrun and /whatsnew pages
> > 
> > Peiying, my first question is then, as those strings do currently exist
> > translated (I am making an assumption here), what is the l10n impact of
> > adding them to these new pages? If they do not exist, of course there is a
> > bigger issue. Thoughts?
> > 
> > 
> > Maciej, do we want to make these same updates to the firefix/developer page
> > or only /firstrun and /whatsnew
> 
> Hey Schalk, thank you for checking. We only wanted to make these changes to
> /firstrun and /whatsnew, NOT the firefox/developer (as we want the user to
> stay on this page and keep the focus on Fx download) .

Thanks!
Also, I will use the links and copy for the links found in https://www.mozilla.org/en-US/firefox/56.0a2
Great, thank you Schalk!
@schalk: the l10n completion status for this page: https://l10n.mozilla-community.org/langchecker/?locale=all&website=0&file=firefox/whatsnew_56.lang - scroll to the bottom, 44% of the locales have completed the page which represents 97% of the user base.
Assignee: schalk.neethling.bugs → nobody
Flags: needinfo?(erenaud)
(In reply to Schalk Neethling [:espressive] from comment #28)
> As mentioned in
> https://docs.google.com/document/d/
> 1OboHPRVEKOgbyEbEzWWg5zMBSCBg8QJIPPTI_Nsmfo8/edit?ts=59df918a
> 
> "I just want to make sure everyone understand this means, if a locale has
> not been localised, there is no fallback i.e. Links will show for localised
> content, no links for those that have not. alainez@mozilla.com Does that
> work for you?"

Removing NI. Let me know if you still need my input here
Flags: needinfo?(alainez)
Commits pushed to master at https://github.com/mozilla/bedrock

https://github.com/mozilla/bedrock/commit/7a617aca26615ccdee81c313c453fa4a455fd725
Fix Bug 1399277, post launch content updates for dev firstrun

https://github.com/mozilla/bedrock/commit/d26bad24956a107a76ff5da6bb9297c6d1747457
Merge pull request #5202 from schalkneethling/bug1399277-post-launch-content-updates-dev-firstrun

Fix Bug 1399277, post launch content updates for dev firstrun
Status: REOPENED → RESOLVED
Closed: 7 years ago → 7 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: