1399751 - Reduce the use of MediaCacheStream::mChannelOffset

Status: RESOLVED FIXED

(Core :: Audio/Video: Playback, enhancement, P3)

Description

[JW Wang [:jwwang] [:jw_wang]]

See bug 1398700. We want to reduce its use so we have less code to reason about its thread-safety and fixing bug 1398700 will be easier.

Comment 1

[JW Wang [:jwwang] [:jw_wang]]

Attachment: Bug 1399751. P1 - pass a block index to AllocateAndWriteBlock() so it doesn't depend on mChannelOffset.

Review commit: https://reviewboard.mozilla.org/r/180068/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/180068/

Comment 2

[JW Wang [:jwwang] [:jw_wang]]

Attachment: Bug 1399751. P2 - pass a block index to FindBlockForIncomingData() so it doesn't depend on mChannelOffset.

Review commit: https://reviewboard.mozilla.org/r/180070/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/180070/

Comment 3

[JW Wang [:jwwang] [:jw_wang]]

Attachment: Bug 1399751. P3 - pass the offset of range request to ChannelMediaResource::OnStartRequest().

So we don't have to look at GetOffset(). We want to reduce the use of
MediaCacheStream::mChannelOffset so it is easier to fix data races about it.

Review commit: https://reviewboard.mozilla.org/r/180072/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/180072/

Comment 4

[Gerald Squelart (he/him) (not at Mozilla since 2022-09-15)]

Comment on attachment 8908430 [details]
Bug 1399751. P1 - pass a block index to AllocateAndWriteBlock() so it doesn't depend on mChannelOffset.

https://reviewboard.mozilla.org/r/180068/#review185236

Comment 5

[Gerald Squelart (he/him) (not at Mozilla since 2022-09-15)]

Comment on attachment 8908431 [details]
Bug 1399751. P2 - pass a block index to FindBlockForIncomingData() so it doesn't depend on mChannelOffset.

https://reviewboard.mozilla.org/r/180070/#review185238

Comment 6

[Gerald Squelart (he/him) (not at Mozilla since 2022-09-15)]

Comment on attachment 8908432 [details]
Bug 1399751. P3 - pass the offset of range request to ChannelMediaResource::OnStartRequest().

https://reviewboard.mozilla.org/r/180072/#review185240

Comment 7

[JW Wang [:jwwang] [:jw_wang]]

Thanks!

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/22dbe1bf55a0
P1 - pass a block index to AllocateAndWriteBlock() so it doesn't depend on mChannelOffset. r=gerald
https://hg.mozilla.org/integration/autoland/rev/f85b473c4964
P2 - pass a block index to FindBlockForIncomingData() so it doesn't depend on mChannelOffset. r=gerald
https://hg.mozilla.org/integration/autoland/rev/9f86654073e2
P3 - pass the offset of range request to ChannelMediaResource::OnStartRequest(). r=gerald

Comment 9

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/22dbe1bf55a0
https://hg.mozilla.org/mozilla-central/rev/f85b473c4964
https://hg.mozilla.org/mozilla-central/rev/9f86654073e2