1399878 - Use LOCAL_INCLUDES instead of CFLAGS in some media moz.build files

Status: RESOLVED FIXED

(Firefox Build System :: General, defect)

Description

[(not currently active) Ted Mielczarek]

I'm not sure why these moz.build files are written this way, but a few moz.build files under media/ set include paths by doing things like `CFLAGS += [ '-I%s/media/libaom/config/win/x64/' % TOPSRCDIR ]`. These are easily translated to `LOCAL_INCLUDES`, which is more sensible and doesn't break my WSL build with absolute Posix paths being passed to cl.exe.

Comment 1

[(not currently active) Ted Mielczarek]

I meant to link the moz.build files in question:
https://dxr.mozilla.org/mozilla-central/rev/f9a5e9ed62103c84e4cde915f4d08f1ce71be83e/media/libaom/moz.build
https://dxr.mozilla.org/mozilla-central/rev/f9a5e9ed62103c84e4cde915f4d08f1ce71be83e/media/libvpx/moz.build

Comment 2

[(not currently active) Ted Mielczarek]

Attachment: bug 1399878 - Use LOCAL_INCLUDES instead of CFLAGS in some media moz.build files.

Review commit: https://reviewboard.mozilla.org/r/179834/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/179834/

Comment 3

[Gregory Szorc [:gps]]

Comment on attachment 8908151 [details]
bug 1399878 - Use LOCAL_INCLUDES instead of CFLAGS in some media moz.build files.

https://reviewboard.mozilla.org/r/179834/#review185572

Weird.

A potential follow-up would be to lint the value of CFLAGS and cousins and reject anti-patterns like this.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/305e742634e5
Use LOCAL_INCLUDES instead of CFLAGS in some media moz.build files. r=gps

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/6cde1d8f17ad
Fix case of LOCAL_INCLUDES; r=me

Comment 6

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/305e742634e5
https://hg.mozilla.org/mozilla-central/rev/6cde1d8f17ad