1400266 - Style the bookmarks and history sidebar tree arrows on Linux

Status: VERIFIED FIXED

(Firefox :: Theme, defect, P5)

Description

[ovidiu boca[:Ovidiu]]

Attachment: sidebar tree Ubuntu 16.04.png

The sidebar tree doesn't respect the specifications, for example, the arrows from the "Bookmarks Toolbar", "Bookmarks Menu" are not the same as the ones from the spec.

Please see the attachment.

Comment 1

[Dão Gottwald [:dao]]

We currently can't style the arrows as specified because of bug 1381453.

Comment 2

[Richard Marti (:Paenglab)]

Attachment: Bug1400266- Linux-twisty.patch

I copied the Windows twisty icons for this patch.

Comment 3

[Mark Banner (:standard8)]

From a quick look, it seems like this could fix bug 1298020 as well (rtl issues), hence adding a dependency.

Comment 4

[Richard Marti (:Paenglab)]

Comment on attachment 8987596 [details] [diff] [review]
Bug1400266- Linux-twisty.patch

Hmm, somehow the r? wasn't applied.

Comment 5

[Dão Gottwald [:dao]]

Comment on attachment 8987596 [details] [diff] [review]
Bug1400266- Linux-twisty.patch

> *  skin/classic/global/in-content/common.css                   (in-content/common.css)
> *  skin/classic/global/in-content/info-pages.css               (in-content/info-pages.css)
>-   skin/classic/global/tree/twisty-clsd.png                    (tree/twisty-clsd.png)
>-   skin/classic/global/tree/twisty-open.png                    (tree/twisty-open.png)
>+  skin/classic/global/tree/twisty-collapsed.svg                (tree/twisty-collapsed.svg)
>+  skin/classic/global/tree/twisty-collapsed-rtl.svg            (tree/twisty-collapsed-rtl.svg)
>+  skin/classic/global/tree/twisty-expanded.svg                 (tree/twisty-expanded.svg)

nit: indentation is off

>+++ b/toolkit/themes/linux/global/tree/twisty-collapsed-rtl.svg
>@@ -0,0 +1,6 @@
>+<!-- This Source Code Form is subject to the terms of the Mozilla Public
>+   - License, v. 2.0. If a copy of the MPL was not distributed with this
>+   - file, You can obtain one at http://mozilla.org/MPL/2.0/. -->
>+<svg width="9" height="9" xmlns="http://www.w3.org/2000/svg" stroke="context-fill" stroke-opacity="context-fill-opacity" stroke-width="1.6" fill="none">

Where does fill-opacity ever get set to a value different than 1?

>+    <path d="m 6.5,0.5 -4,4 4,4"/>

nit: use two spaces indentation

Comment 6

[Richard Marti (:Paenglab)]

(In reply to Dão Gottwald [::dao] from comment #5)
> Comment on attachment 8987596 [details] [diff] [review]
> Bug1400266- Linux-twisty.patch
> 
> Where does fill-opacity ever get set to a value different than 1?

Nowhere yet. It's only ready if it's maybe used in the sidebar theming bug. Should I remove it completely? Then I'll do the same on Windows.

Comment 7

[Dão Gottwald [:dao]]

(In reply to Richard Marti (:Paenglab) from comment #6)
> Should I remove it completely? Then I'll do the same on Windows.

Yes, please.

Comment 8

[Richard Marti (:Paenglab)]

Attachment: Bug1400266- Linux-twisty.patch

(In reply to Dão Gottwald [::dao] from comment #5)
> Comment on attachment 8987596 [details] [diff] [review]
> Bug1400266- Linux-twisty.patch
> 
> nit: indentation is off

Fixed.

> Where does fill-opacity ever get set to a value different than 1?

Removed, also on Windows.

> >+    <path d="m 6.5,0.5 -4,4 4,4"/>
> 
> nit: use two spaces indentation

Fixed, also on Windows.

Comment 9

[Dão Gottwald [:dao]]

Comment on attachment 8988768 [details] [diff] [review]
Bug1400266- Linux-twisty.patch

Thanks!

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/93972d67be61
Use SVG icons for the twisties on Linux. r=dao

Comment 11

[Cristina Coroiu [:ccoroiu]]

https://hg.mozilla.org/mozilla-central/rev/93972d67be61

Comment 12

[ovidiu boca[:Ovidiu]]

I verified this issue on Ubuntu 16.04 with FF Nightly 63.0a1(2018-07-01) and I can confirm the fix. I will mark this as verified fixed.