1401561 - Make sure the JAWS prompt doesn't trigger in non-e10s

Status: VERIFIED FIXED

(Core :: Disability Access APIs, defect, P1)

Description

[Jim Mathies [:jimm]]

Thought of this last night and it looks like it may be possible, I need a e10s check in here [1] somewhere.

[1] https://bugzilla.mozilla.org/attachment.cgi?id=8905940&action=diff

Comment 1

[Jim Mathies [:jimm]]

Attachment: patch

Comment 2

[Jim Mathies [:jimm]]

Comment on attachment 8911327 [details] [diff] [review]
patch

Add a check to make sure we don't prompt if e10s is off. Looks like felipe is on pto, Jared, would you mind looking this over? It's a very straight forward change.

Comment 3

[Liz Henry (:lizzard) (relman/hg->git project)]

Double checking, jimm, jaws, is this for 57 only?

Comment 4

[Jared Wein [:jaws] (please needinfo? me)]

If bug 1385991 gets uplifted to 56 then we will need to uplift this to 56 as well.

Comment 5

[Jim Mathies [:jimm]]

Attachment: patch

Comment 6

[Jim Mathies [:jimm]]

(In reply to Liz Henry (:lizzard) (needinfo? me) from comment #3)
> Double checking, jimm, jaws, is this for 57 only?

57 only.

Comment 7

[Jim Mathies [:jimm]]

Attachment: patch

- updated commit message with r+ from jared

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/d8d8c0972cb4
Avoid prompting about compatibility issues with JAWS when e10s is pref'd off. r=jaws

Comment 9

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/d8d8c0972cb4

Comment 10

[Ritu Kothari (:ritu) (Inactive, please n-i to RyanVM, jcristau, or pascal)]

Hi Jim, should we uplift this fix to Beta57?

Comment 11

[Jim Mathies [:jimm]]

Comment on attachment 8911946 [details] [diff] [review]
patch

Approval Request Comment
[Feature/Bug causing the regression]:
bug 1385991 
[User impact if declined]:
buggy prompting code for a11y
[Is this code covered by automated tests?]:
no
[Has the fix been verified in Nightly?]:
yes
[Needs manual test from QE? If yes, steps to reproduce]: 
yes, 

STR: 
1) disable e10s in 57, close firefox
2) launch old 8.0 JAWS client
3) launch firefox

expected result: no e10s+a11y prompt
[List of other uplifts needed for the feature/fix]:
[Is the change risky?]:
no
[Why is the change risky/not risky?]:
well understood change
[String changes made/needed]:
none

Comment 12

[Sylvestre Ledru [:Sylvestre]]

Comment on attachment 8911946 [details] [diff] [review]
patch

Improve jaws support, taking it.
Should be in 57b5

Comment 13

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-beta/rev/75e965089708

Comment 14

[Alexandru Simonca [:asimonca], Release Desktop QA]

Verified fixed in Beta 57.b13. 
There is no prompt showing up in Nightly with e10s ON or OFF. This may be because of Bug 1413599 comment 5.

Comment 15

[Alexandru Simonca [:asimonca], Release Desktop QA]

Verified Fixed in 58.b6. No prompt is shown when e10s is off.