1402460 - Row selection styles should have more specificity than row hovering

Status: RESOLVED FIXED

(DevTools :: JSON Viewer, enhancement, P3)

Description

[Oriol Brufau [:Oriol]]

1. Load data:application/json,[1,2]
2. Hover the first row, it becomes lightly highlighted.
3. Click it. The row becomes selected but this is not observable because the row is still hovered.
4. Hover the second row. The first row suddenly becomes heavily highlighted. This is confusing.

Expected:
1. Load data:application/json,[1,2]
2. Hover the first row, it becomes lightly highlighted.
3. Click it. The row becomes heavily highlighted.
4. Hover the second row. The second row becomes lightly highlighted and the first one stays heavily highlighted.

Comment 1

[Oriol Brufau [:Oriol]]

Attachment: Bug 1402460 - Let row selection styles have more precedence than row hovering

Review commit: https://reviewboard.mozilla.org/r/183978/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/183978/

Comment 2

[Jan Honza Odvarko [:Honza] (always need-info? me)]

Comment on attachment 8912652 [details]
Bug 1402460 - Let row selection styles have more precedence than row hovering

https://reviewboard.mozilla.org/r/183978/#review190064

Works nice, thanks!

R+, but please put a comment in the code explaining why we are using `not(.selected)`.

Honza

Comment 3

[Oriol Brufau [:Oriol]]

Comment on attachment 8912652 [details]
Bug 1402460 - Let row selection styles have more precedence than row hovering

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/183978/diff/1-2/

Comment 4

[Oriol Brufau [:Oriol]]

OK, and I have also simplified some styles. I don't now how to request review again, so I use needinfo.

Comment 5

[Jan Honza Odvarko [:Honza] (always need-info? me)]

Comment on attachment 8912652 [details]
Bug 1402460 - Let row selection styles have more precedence than row hovering

https://reviewboard.mozilla.org/r/183978/#review190584

LGTM thanks!

Honza

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/de65572822c6
Let row selection styles have more precedence than row hovering r=Honza

Comment 7

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/de65572822c6