1403164 - Can't remove a pinned site

Status: RESOLVED INCOMPLETE

(Firefox for Android Graveyard :: Activity Stream, defect, P3)

Description

[Sorina Florean [:sflorean]]

Environment: 
Device: Samsung Galaxy Note 4 (Android 5.0.1),Xiaomi Mi Pad 2 (Android 5.1 x86) ;
Build: Nightly 58.0a1 (2017-09-25);

Steps to reproduce:
1. Launch Fennec and long tap on any item from Top Sites list;
2. Choose 'Pin Site';
3. Choose 'Remove'.

Expected result:
The item has been removed from both the 'History' and the 'Top Sites' panels.

Actual result:
The item can't be removed.

Comment 1

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

There are two different kinds of top sites tiles:
1. Top sites from history
2. Suggested sites

With 1), selecting "Delete from history" will delete the item from history but keep the top site pinned. You can unpin the site with "Unpin site". Additionally, it will add a "Remove" item because we consider top sites items without history to be suggested sites. However, this item does nothing because it assumes we're working with suggested sites. (oops!) Unpinning the site will cause it disappear from top sites.

For 2), selecting "Remove" will take no action ("Delete from history" is shown if the site has been visited before and the flow is more complicated). You can unpin the site with "Unpin site" and it'll disappear (unless it was visited).

We can fix both of these issues by unpinning a site when "Delete from history" or "Remove" is clicked, but it calls into question our assumption that top sites without history are suggested sites (I filed bug 1403354 for a bug I found because of this). I also wonder: is it intuitive that "Delete from history" will remove a site from top sites?

For the "Delete from history" case, we should also consider hiding the site if it's a suggested site because it doesn't come for free.

Comment 2

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

[triage] Bulk edit from title: this is a non-critical issue. Please remove priority if you wish this to be re-triaged.

Comment 3

[Sorina Florean [:sflorean]]

Note: Top Sites Grid: on build 61.0b3 the "remove" option from context menu doesn't work for bookmarks either.

Comment 4

[BMO Automation]

We have completed our launch of our new Firefox on Android. The development of the new versions use GitHub for issue tracking. If the bug report still reproduces in a current version of [Firefox on Android nightly](https://play.google.com/store/apps/details?id=org.mozilla.fenix) an issue can be reported at the [Fenix GitHub project](https://github.com/mozilla-mobile/fenix/). If you want to discuss your report please use [Mozilla's chat](https://wiki.mozilla.org/Matrix#Connect_to_Matrix) server https://chat.mozilla.org and join the [#fenix](https://chat.mozilla.org/#/room/#fenix:mozilla.org) channel.