1404260 - Top Sites are reduced to only 3 when performing sync

Status: RESOLVED INCOMPLETE

(Firefox for Android Graveyard :: Activity Stream, defect, P5)

Description

[Bogdan Surd, QA [:bsurd, NI]]

Devices: 
 - Nexus 6 (Android 7.1.1);
 - Note 4 (Android 5.1.1).
Builds:
 - 57.0b4;
 - 58.0a1 (2017-09-28);


Steps to reproduce:
 1. Open Fennec and pin any non default top site (eg. pocket story).
 2. Login with an account that has a lot of bookmarks and perform sync

Expected result:
 Sync is performed successfully and everything remains in place.

Actual result:
 After sync finishes the Top Sites tiles are reduced to a number of 3.

Notes:
 After removing one of the top sites all of the other ones are restored.
 These steps may not be precise as it does not always reproduce. I've noticed this happen on several occasions but am yet to narrow down the exact steps.

Comment 1

[Nevin Chen(Not active on Bugzilla)]

Hi Jing Wei
Could you please take a look?

Comment 2

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

Recommendation for AS triage: P3. We didn't change our top sites algorithm much so this sounds like an existing issue. Also, it's unclear under which conditions this occurs and thus whether it would affect regular users (e.g. new profiles only? existing profiles only? How many bookmarks are we talking here?). Note: this research could also be moved to the sync team.

That being said, I have seen an issue in my top sites on my personal device where sites I don't visit often (e.g. a duckduckgo search) is in my top sites despite there being other sites I believe I visit more frequently on device. In this bug, the sync seems to be modify the top sites unexpectedly, perhaps like my local top sites – I wonder if this is at all related?

Note: I don't have an account with lots of bookmarks to sync so I did not attempt to reproduce.

Comment 3

[Nevin Chen(Not active on Bugzilla)]

Hi! Is this still happening?

Comment 4

[Bogdan Surd, QA [:bsurd, NI]]

Hello,

Yes this issue still seems to reproduce from time to time.

Comment 5

[Firefox Bug Husbandry Bot]

Re-triaging per https://bugzilla.mozilla.org/show_bug.cgi?id=1473195

Needinfo :susheel if you think this bug should be re-triaged.

Comment 6

[miralobontiu]

Device: Sony Xperia Z2 (Android 6.0.1)
Build: Beta 64.0b12

I was able to reproduce the issue, but not following the exact STR from Comment 0.
I had about 6 tabs opened and I performed a sync, but not pinned any site.

Comment 7

[BMO Automation]

We have completed our launch of our new Firefox on Android. The development of the new versions use GitHub for issue tracking. If the bug report still reproduces in a current version of [Firefox on Android nightly](https://play.google.com/store/apps/details?id=org.mozilla.fenix) an issue can be reported at the [Fenix GitHub project](https://github.com/mozilla-mobile/fenix/). If you want to discuss your report please use [Mozilla's chat](https://wiki.mozilla.org/Matrix#Connect_to_Matrix) server https://chat.mozilla.org and join the [#fenix](https://chat.mozilla.org/#/room/#fenix:mozilla.org) channel.