1404318 - Colon sign is displayed in "about:preferences#privacy" page in Clear history sub-dialog

Status: VERIFIED FIXED

(Firefox :: Settings UI, defect, P3)

Description

[Petruta Horea [:phorea], Desktop QA]

+++ This bug was initially created as a clone of Bug #1399075 +++

[Affected versions]: 
Nightly 58.0a1
Firefox 57.0 beta 4

[Affected platforms]:
Platforms: Windows 10 x 64, Mac OS X 10.12 and Ubuntu 16.04 x64.

[Steps to reproduce]:
1. Open firefox.
2. Go to "about:preferences#privacy" - History sub-section
3. Check "Clear history when Nightly closes" option and then click on "Settings..." button.

[Expected result]:
All colon signs on sub-dialogs should be removed.

[Actual result]:
Colon sign is displayed in "Settings for Clearing History" sub-dialog, on "When I quit Nightly, it should automatically clear all:" sentence

[Note]:
On Cookies sub-dialog, there are colons for every cookie property (eg: "Name: abc")

Comment 1

[Ricky Chien [:rickychien] (inactive)]

Attachment: Bug 1404318 - Remove redundant colon sign in preferences/sanitize.xul

Review commit: https://reviewboard.mozilla.org/r/185464/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/185464/

Comment 2

[Ricky Chien [:rickychien] (inactive)]

Comment on attachment 8914144 [details]
Bug 1404318 - Remove redundant colon sign in preferences/sanitize.xul

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/185464/diff/1-2/

Comment 3

[Jared Wein [:jaws] (please needinfo? me)]

Comment on attachment 8914144 [details]
Bug 1404318 - Remove redundant colon sign in preferences/sanitize.xul

https://reviewboard.mozilla.org/r/185464/#review190474

Comment 4

[Jared Wein [:jaws] (please needinfo? me)]

Changing to wontfix for 57 since this touches strings and 57-Beta is string frozen.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/98a81519d59d
Remove redundant colon sign in preferences/sanitize.xul r=jaws

Comment 6

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/98a81519d59d

Comment 7

[Petruta Horea [:phorea], Desktop QA]

Verified as fixed in Nightly 58.0a1 2017-10-04 under Win 10 64-bit and Mac OS X 10.12.

Are the colons in Cookies details section [1] expected or should I file a new bug for that? Thank you!

[1] https://drive.google.com/file/d/0B7jBNZBM3mz-R0VHOVpLdG1nc3c/view?usp=sharing

Comment 8

[Petruta Horea [:phorea], Desktop QA]

Sorry, wrong flag.

Comment 9

[Ricky Chien [:rickychien] (inactive)]

It's by design, thanks!