1404556 - u2fhud build breakage on musl libc

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect)

Description

[Jory A. Pratt [:anarchy]]

error[E0308]: mismatched types
  --> /var/tmp/portage/www-client/firefox-57.0_beta4/work/firefox-57.0b4/dom/webauthn/u2f-hid-rs/src/linux/hidraw.rs:60:46
   |
60 |             from_unix_result(libc::ioctl(fd, ioc as libc::c_ulong, val))
   |                                              ^^^^^^^^^^^^^^^^^^^^ expected i32, found u64
...
66 | ioctl!(READ, hidiocgrdescsize, b'H', 0x01; ::libc::c_int);
   | ---------------------------------------------------------- in this macro invocation

error[E0308]: mismatched types
  --> /var/tmp/portage/www-client/firefox-57.0_beta4/work/firefox-57.0b4/dom/webauthn/u2f-hid-rs/src/linux/hidraw.rs:60:46
   |
60 |             from_unix_result(libc::ioctl(fd, ioc as libc::c_ulong, val))
   |                                              ^^^^^^^^^^^^^^^^^^^^ expected i32, found u64
...
67 | ioctl!(READ, hidiocgrdesc, b'H', 0x02; /*struct*/ ReportDescriptor);
   | -------------------------------------------------------------------- in this macro invocation

error: aborting due to 2 previous errors

Comment 1

[Jan Honza Odvarko [:Honza] (always need-info? me)]

@Andrea: Is it platform DOM component? (doesn't seem like dev tools issue).

Honza

Comment 2

[Jory A. Pratt [:anarchy]]

https://doc.rust-lang.org/libc/x86_64-unknown-linux-musl/libc/fn.ioctl.html

pub unsafe extern "C" fn ioctl(fd: c_int, request: c_int, ...) -> c_int

https://doc.rust-lang.org/libc/x86_64-unknown-linux-gnu/libc/fn.ioctl.html

pub unsafe extern "C" fn ioctl(fd: c_int, request: c_ulong, ...) -> c_int

As you can see linux-gnu uses the Linux Prototypes while, musl uses the Posix Prototypes.

Comment 3

[Jory A. Pratt [:anarchy]]

Attachment: Use posix prototypes on musl

This is just a quick hack for those who are working on musl. We will need to find an appropriate solution that can be landed in tree.

Comment 4

[Tim Taubert [:ttaubert] (inactive)]

Jory, can you please try the patch [1] I just submitted and report back whether that works for you? Thanks!

[1] https://phabricator.services.mozilla.com/D96?download=true

Comment 5

[Jory A. Pratt [:anarchy]]

Works as expected, tested with glibc and musl setups.

Comment 6

[Tim Taubert [:ttaubert] (inactive)]

(In reply to Jory A. Pratt from comment #5)
> Works as expected, tested with glibc and musl setups.

Great, thank you!

Comment 7

[Phabricator Automation]

Comment on attachment 8915074 [details]
Bug 1404556 - Support libc::ioctl() call on musl libc

J.C. Jones [:jcj] has approved the revision.

https://phabricator.services.mozilla.com/D96#2037

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/d2b9f46b0447
Support libc::ioctl() call on musl libc

Comment 9

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/d2b9f46b0447

Comment 10

[Jory A. Pratt [:anarchy]]

[Tracking Requested - why for this release]:

Is a simple compile fix, nothing has changed that would cause breakage for glibc variants of Linux.

Comment 11

[Ryan VanderMeulen [:RyanVM]]

Please request Beta approval on this patch if it's something you feel should be fixed in 57 still.

Comment 12

[Tim Taubert [:ttaubert] (inactive)]

Comment on attachment 8915074 [details]
Bug 1404556 - Support libc::ioctl() call on musl libc

Approval Request Comment
[Feature/Bug causing the regression]: bug 1388843
[User impact if declined]: No user impact, but may affect distributors.
[Is this code covered by automated tests?]: No.
[Has the fix been verified in Nightly?]: Yes.
[Needs manual test from QE? If yes, steps to reproduce]: 
[List of other uplifts needed for the feature/fix]:
[Is the change risky?]: No.
[Why is the change risky/not risky?]: It's a build-time change that doesn't alter behavior.
[String changes made/needed]: None.

I think this is something we should fix for 57. It's a change that will allow building Firefox 57 with musl. We're currently breaking things like Gentoo's "Hardened musl" project, and in general people that want to link against musl.

Comment 13

[Ritu Kothari (:ritu) (Inactive, please n-i to RyanVM, jcristau, or pascal)]

Comment on attachment 8915074 [details]
Bug 1404556 - Support libc::ioctl() call on musl libc

NPOTB, Beta57+

Comment 14

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-beta/rev/a820e59b932a