1406338 - Show favicon in tabs tray page

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: Theme and Visual Design, defect)

Description

[Jing-wei Wu [:jwu]]

Attachment: favicon shown in tabs tray

We would like to show favicon in tabs tray page, just like Firefox for iOS. Check attachment for the visual spec.

Comment 1

[Jing-wei Wu [:jwu]]

Attachment: Bug 1406338 - Part 1: Support applying specific text size while creating a favicon.

Review commit: https://reviewboard.mozilla.org/r/187594/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/187594/

Comment 2

[Jing-wei Wu [:jwu]]

Attachment: Bug 1406338 - Part 2: Show favicons in tabs tray page.

Review commit: https://reviewboard.mozilla.org/r/187596/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/187596/

Comment 3

[Nevin Chen(Not active on Bugzilla)]

Comment on attachment 8916477 [details]
Bug 1406338 - Part 2: Show favicons in tabs tray page.

https://reviewboard.mozilla.org/r/187596/#review192634

Comment 4

[Nevin Chen(Not active on Bugzilla)]

Comment on attachment 8916476 [details]
Bug 1406338 - Part 1: Support applying specific text size while creating a favicon.

https://reviewboard.mozilla.org/r/187594/#review192636

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/ef0e62e2956d
Part 1: Support applying specific text size while creating a favicon. r=nechen
https://hg.mozilla.org/integration/autoland/rev/5e2772fd3b67
Part 2: Show favicons in tabs tray page. r=nechen

Comment 6

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/ef0e62e2956d
https://hg.mozilla.org/mozilla-central/rev/5e2772fd3b67

Comment 7

[Jing-wei Wu [:jwu]]

Comment on attachment 8916476 [details]
Bug 1406338 - Part 1: Support applying specific text size while creating a favicon.

Approval Request Comment
[Feature/Bug causing the regression]:
Show favicon in tabs tray page

[User impact if declined]:
User cannot see favicon on tabs tray page. This patch is to keep visual consistent with Fennec iOS. We  want to uplift this patch as part of Photon related work.

[Is this code covered by automated tests?]:
No

[Has the fix been verified in Nightly?]:
Not yet

[Needs manual test from QE? If yes, steps to reproduce]: 
Yes, the STR is
1. Launch Fennec and press the 'tabs' button to enter tabs tray page,
2. Check if the favicon for each tab is shown correctly.

[List of other uplifts needed for the feature/fix]:
Another 1 patch needed for uplift: attachment 8916477 [details]

[Is the change risky?]:
No

[Why is the change risky/not risky?]:
We copy the logic of favicon loading from bookmarks panel to tabs tray page. This code logic should work fine and be tested thoroughly in several releases.

[String changes made/needed]:
No

Comment 8

[Sorina Florean [:sflorean]]

Verified as fixed in build 58.0a1 (2017-10-11);
Device: Sony Xperia Z5 Premium (Android 6.0.1).

Comment 9

[Ritu Kothari (:ritu) (Inactive, please n-i to RyanVM, jcristau, or pascal)]

Comment on attachment 8916476 [details]
Bug 1406338 - Part 1: Support applying specific text size while creating a favicon.

Fennec Photon, Beta57+

Comment 10

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-beta/rev/cfafb2da1e66
https://hg.mozilla.org/releases/mozilla-beta/rev/10ac938d97d5

Comment 11

[u549602]

Verified as fixed in build 57.0b9;
Device: Pixel C (Android 7.1.1).