14065 - UI: remove non-news prefs from news server panel

Status: VERIFIED FIXED

(SeaMonkey :: MailNews: Account Configuration, defect, P3)

Description

[Ninoschka Baca]

Build 1999091509M11: Win32/NT4
(Linux and Mac: Have noticed these problems in general and will check with
detail later)

Overview: The following issues do not match the spec when a Server Panel is
selected.
Spec- http://gooey/client/5.0/specs/mail/accountSetup/accountSetup.html


1. If the Mail Server level is selected then it should display "Earthlink Server
Settings" at the top of the right panel.

2. According to spec when the News Server level is selected then it should
dispay "News Server Settings" at the top of the right panel. Is this correct?

POP Server level selected
3. Problem: Add checkboxes
Expect: Check boxes for "Log onto this account at startup of Mail".

4. Add the following:
a. Statement "Local mail directory:" where the "L" is underlined.
b. Box with a path showing the local mail directory.
c. "Choose..." button to the right of the path showing local mail directory.

IMAP/Server level selected
5. Problem: Some checkboxes and dropdown boxes are missing.
Expect: Add the following:
a. Checkbox: "Log onto this accout at startup of Mail"
b. Checkbox: "Mark new folders for offline download", where the "M" is
underlined.
c. Checkbox: "Use secure connection (SSL)", where the "U" is underlined. Isn't
SSL out?
d. Dropdown: "When I delete a message:" and a drop down box with the three
scenarios. Do you need more detail?
e. Checkbox: "Clean up ("Expunge") Inbox on Exit" where the "C" is underlined.
f. Checkbox: "Empty Trash on Exit" where the "E" is underlined.
g. "Advanced..." button
h. Statement "Local mail directory:" where the "L" is underlined.
i. Box with a path showing the local mail directory.
j. "Choose..." button to the right of the path showing local mail directory.

6. Problem: Two borders are displayed.
Expect: The two borders should be removed. Currently the first border begins
with the text "Server Type:" and the second border begins with the text "leave
messages on server".

News Server
7. Problem: On the "Server Type:" line it states "News server".
Expect: It should state "Newsgroup server (NNTP)". Is this suppose to recognize
the news server and insert the name. For instance would it display as
"News.mozilla.org server (NNTP)"?

8. Problem: There is no Port entry.
Expect: I should have a text string "Port:" followed by a text box with "119"
inserted by default. This text box should be left alligned with the "Server
Name:" text box above.

9. Problem: Extra entries.
Expect: Remove the following entries:
- Username:
- Save password
- Check for new messages every # minutes
- Leave messages on server when deleted locally
- Empty Trash on exit

10. Problem: Missing checkboxes.
Expect: Add the following checkbox entries:
- "Always use name and password" where the "A" is capitalized.
- "Ask me before downloading more than # messages" where the "k" in "ask" is
underlined and the "m" in "messages" is underlined.

11. Add the following:
a. Statement "Local news directory:" where the "L" is underlined.
b. Box with a path showing the local news directory.
c. "Choose..." button to the right of the path showing local mail directory.

Comment 1

[Ninoschka Baca]

Setting QA Contact to nbaca.

Comment 2

[lchiang]

(target milestone is M11 or M12 - add to beta tracking bug)

Comment 3

[Alec Flett]

Status as of today:
1. Latered to after PR1.
2. I think it should do the same thing as #1.
3. Latered to after PR1.
4. Just fixed 4a and 4b, we're not doing 4c for PR1
5. 5a latered to after PR1
   5b no offline support in PR1, later for now
   5c yup, no SSL
   5d-f Done.
   5g no advanced IMAP dialog in PR1
   5h,i done
   5j latered till after PR1
6. borders have been removed.
7. done
8. latering till after PR1
9. Still open
10a Still open
10b done.
11a,b done.
11c latered to after PR1

Notes: I think we'll probably not do the Underlining thing for PR1, because I
don't believe it's been implemented yet.... so I'll just leave that one alone.

To summarize:
The following issues are still open:
9. Remove bogus news prefs from server panel
10. Add news-specific prefs to server panel

Comment 4

[Alec Flett]

In case seth is interested in news stuff
We should probably hide some of this stuff with stylesheets.
it would be pretty simple:
just do an hidden form field with the name "server.type"
Then put it inside a div along with all the other stuff we want to hide.
then make a style rule that says, hide all divs that contain an input field with
value "nntp"

I'll have to brush up on my css, but that's probably something like

div > input[value="nntp"] {
  display: none;
}

Comment 5

[Phil Peterson]

M14

Comment 6

[Phil Peterson]

Can we separate out the remaining issues into new bugs? This one is too old and
hard to follow.

Comment 7

[Alec Flett]

#9 and #10 are the only valid things left in this bug.
#10 is almost done, I'll check in tonight

changing summary to reflect #9

Comment 8

[Alec Flett]

you know what? this really isn't hurting anything.

Comment 9

[laurel]

Regarding item 10a (always use name/password) for news server panel:
I was talking with Alec about the new meshing with single signon/wallet usage
for authenticating to news/nntp servers. He mentioned this would only be
accessible to change/unchange through the wallet/single signon dialogs and we
would no longer see password oriented pref(s) in the server panel for news/nntp.

If that is the case, item 10a has changed from the original writing of this bug
report and current Account Setup spec doesn't mention this.  (FYI for nbaca, cc
huang for news testing info, cc jglick for potential spec update)

Comment 10

[selmer (gone)]

Minor UI fixups to M18.  If this is incorrect, please adjust.

Comment 11

[laurel]

I disagree with the M18 milestone.  I think we should try to get the account
settings panels pretty much with the right prefs by Beta2.  Having mail prefs on
a news server panel isn't a minor UI thing in my opinion by this time.  Wording
errors might be minor UI problems, but having wrong type of prefs appear is not
so minor.

Comment 12

[selmer (gone)]

I meant minor in the sense of not much work required.  I leave it up to Alec to
decide whether M18 is right or not.

Comment 13

[Alec Flett]

I'm going to have to agree with steve - we do a pretty good job of sorting out
the imap or pop-specific prefs, the only ones that get shown are global prefs
that apply to everybody EXCEPT news...and since we now have newsbiff, that means
even fewer non-news prefs.

Comment 14

[Alec Flett]

well, I did this while I was skinning the dialog, it was too simple not to do it
while I was there.

Comment 15

[Ninoschka Baca]

Build 2000-05-18-09M16: Win95, Linux 6.0, Mac 9.04
Reopening

News Server Panel:
1. Displays "User Name: " entry yet this is not in the spec. Does this apply to 
News?

2. The "Port" label and text box are not present. They should appear after the 
"Server Name".

3. The "Use secure connection (SSL)" is not in the spec yet it displays in the 
latest build. 

4. "Check for new messages every # minutes" should be removed.

5. The spec references "Always use name and password" and the latest build does 
not have this entry. I'm not sure of the Master Password/Single Sign-On 
implementation. Should this stay or be removed?

Comment 16

[(not reading, please use [e-mail] instead)]

Build 2000-05-18-09M16: Win95, Linux 6.0, Mac 9.04
Reopening

News Server Panel:

> 1. Displays "User Name: " entry yet this is not in the spec. Does this apply
to 
> News?
yes, we need username for news.  some news accounts (like my news.supernews.com
account) requires a username and password for everything.



> 2. The "Port" label and text box are not present. They should appear after the 
> "Server Name".
we need that.

> 3. The "Use secure connection (SSL)" is not in the spec yet it displays in the 
> latest build. 
it should stay.  we had snews up until recently, when both snews and imaps
broke.

>4. "Check for new messages every # minutes" should be removed.

no, we have news biff in 6.0.  (although there is currently a bug on it.)


>5. The spec references "Always use name and password" and the latest build does 
>not have this entry. I'm not sure of the Master Password/Single Sign-On 
>implementation. Should this stay or be removed?

this is pushed authentication.  it should stay (although pushed auth doesn't
full work yet, I have a bug on it.)

damn, a lot has regressed.  :(

Comment 17

[Alec Flett]

no, alot hasn't regressed, and in fact I'd argue that we can re-close this bug 
since all of the issues ninoschka brought up have changed (and the spec needs to 
be updated)

Jennifer, can you update the spec according to seth's comment?

The only issue up in the air is the whole save password issue, and I think 
that's coming out of EVERY server, not just news, and Jennifer has filed a bug 
on me already.

Comment 18

[Alec Flett]

oh, missed that #3 was a "needed" - I think we should add another bug for this, 
for all servers, since fixing this bug (which was for hiding non-news prefs) has 
nothing to do with the port.

Comment 19

[Ninoschka Baca]

Verified.

- Bug# 39880 is logged to track the "port" issue.
- With the 2000-05-18-09M16 build I noticed that none of the server panels have 
a "Save Password" reference. I looked for a bug referencing this but couldn't 
find one. There was one logged by Esther but is was set to Invalid. I won't log 
a new bug since it's working as Alec says it should work.

Comment 20

[jglick]

Spec updated. Sorry for the delay.