1406845 - AddMesaSysfsPaths: Resource leak on dir

Status: RESOLVED FIXED

(Core :: Security: Process Sandboxing, defect)

Comment 1

[Sylvestre Ledru [:Sylvestre]]

Attachment: Bug 1406845 - AddMesaSysfsPaths: Resource leak on dir

Review commit: https://reviewboard.mozilla.org/r/187646/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/187646/

Comment 2

[Gian-Carlo Pascutto [:gcp]]

Comment on attachment 8916519 [details]
Bug 1406845 - AddMesaSysfsPaths: Resource leak on dir

https://reviewboard.mozilla.org/r/187646/#review192722

I missed this because my local manpages don't mention the existence of closedir anywhere in the opendir manpage, aside listing it among many other lib calls in SEE ALSO.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/656e8186307b
AddMesaSysfsPaths: Resource leak on dir r=gcp

Comment 4

[Jed Davis [:jld] ⟨⏰|UTC-7⟩ ⟦he/him⟧]

Comment on attachment 8916519 [details]
Bug 1406845 - AddMesaSysfsPaths: Resource leak on dir

https://reviewboard.mozilla.org/r/187646/#review192824

Well that's embarrassing.  (And I'm considering filing a bug to add UniquePtr-based wrappers for everything from `FILE*` to `posix_spawn_file_actions_t` so it's harder to make this kind of mistake in the future.)

Comment 5

[Sylvestre Ledru [:Sylvestre]]

Well, C and C++ are embarrassing ... :)
This is why we run static analyzers. We are working on detecting this pattern at review phase.

Comment 6

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/656e8186307b

Comment 7

[Ritu Kothari (:ritu) (Inactive, please n-i to RyanVM, jcristau, or pascal)]

Comment on attachment 8916519 [details]
Bug 1406845 - AddMesaSysfsPaths: Resource leak on dir

This is needed for uplifting the fix for bug 1401666 to 57.

Comment 8

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-beta/rev/142a0743821c