1409559 - Hard-coded report URLs for Safe Browsing detection errors

Status: NEW

(Toolkit :: Safe Browsing, enhancement, P3)

Description

[François Marier [:francois]]

The URLs for reporting detection mistakes in malware and phishing lists are hardcoded to stopbadware.org and safebrowsing.google.com:

https://searchfox.org/mozilla-central/rev/dca019c94bf3a840ed7ff50261483410cfece24f/browser/base/content/content.js#185
https://searchfox.org/mozilla-central/rev/dca019c94bf3a840ed7ff50261483410cfece24f/browser/base/content/content.js#195

instead of using the built-in redirections:

https://%LOCALE%.malware-error.mozilla.com/?hl=%LOCALE%&url=
https://%LOCALE%.phish-error.mozilla.com/?hl=%LOCALE%&url=

that are defined in:

browser.safebrowsing.provider.google.reportMalwareMistakeURL
browser.safebrowsing.provider.google.reportPhishMistakeURL
browser.safebrowsing.provider.google4.reportMalwareMistakeURL
browser.safebrowsing.provider.google4.reportPhishMistakeURL

The patch in bug 1409348 will fix this issue in the most common case where the provider is Google.

We should deal with providers without a report URL in a better: use different copy and remove the "report detection problem" link.

Comment 1

[Takanori MATSUURA]

(In reply to François Marier [:francois] from comment #0)

https://searchfox.org/mozilla-central/rev/dca019c94bf3a840ed7ff50261483410cfece24f/browser/base/content/content.js#185
https://searchfox.org/mozilla-central/rev/dca019c94bf3a840ed7ff50261483410cfece24f/browser/base/content/content.js#195

These lines are removed by bug 1464552.

Comment 2

[Dimi Lee [ooo 16.04 - 21.04］]

(In reply to Takanori MATSUURA from comment #1)

(In reply to François Marier [:francois] from comment #0)

https://searchfox.org/mozilla-central/rev/dca019c94bf3a840ed7ff50261483410cfece24f/browser/base/content/content.js#185
https://searchfox.org/mozilla-central/rev/dca019c94bf3a840ed7ff50261483410cfece24f/browser/base/content/content.js#195

These lines are removed by bug 1464552.

And right now they are moved to
https://searchfox.org/mozilla-central/rev/5cb522c7baba24e55874809e0e206b001494c1e9/browser/actors/BlockedSiteChild.jsm#79