1409915 - MinGW's IDWriteFontFace1 is broken

Status: RESOLVED FIXED

(Firefox Build System :: General, enhancement)

Description

[Tom Ritter [:tjr] (OOTO until 4/30 at least)]

See https://bugzilla.mozilla.org/show_bug.cgi?id=1372958#c10

Jacek commited a patch, we just need to bump the MinGW version.

Comment 1

[Tom Ritter [:tjr] (OOTO until 4/30 at least)]

Attachment: Bug 1409915 Bump MinGW version to fix a broken IDWriteFontFace1 declaration

Review commit: https://reviewboard.mozilla.org/r/190884/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/190884/

Comment 2

[Tom Ritter [:tjr] (OOTO until 4/30 at least)]

Comment on attachment 8919943 [details]
Bug 1409915 Bump MinGW version to fix a broken IDWriteFontFace1 declaration

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/190884/diff/1-2/

Comment 3

[Nathan Froyd [:froydnj]]

Comment on attachment 8919943 [details]
Bug 1409915 Bump MinGW version to fix a broken IDWriteFontFace1 declaration

https://reviewboard.mozilla.org/r/190884/#review196084

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/e75759bfeb32
Bump MinGW version to fix a broken IDWriteFontFace1 declaration r=froydnj

Comment 5

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/e75759bfeb32

Comment 6

[(Away)]

I can't tell if I'm reading the source history on sf correctly... does your change also fix IDWriteFontFace2 in dwrite_2.h?

Comment 7

[Jacek Caban]

Ah, right, GetMetrics should be changed there too. Good catch. (Duplicated GetMetrics is relevant only for C, not for C++, so as far as Mozilla is considered, it should be fine).