Closed
Bug 1410088
Opened 7 years ago
Closed 7 years ago
avoid unnecessary refcounting in LabeledEventQueue::GetEvent
Categories
(Core :: XPCOM, enhancement)
Core
XPCOM
Tracking
()
RESOLVED
FIXED
mozilla58
| Tracking | Status | |
|---|---|---|
| firefox58 | --- | fixed |
People
(Reporter: froydnj, Assigned: froydnj)
References
(Blocks 1 open bug)
Details
Attachments
(1 file)
|
2.82 KB,
patch
|
erahm
:
review+
|
Details | Diff | Splinter Review |
We can do a better job of refcounting here.
|
Assignee | |
Comment 1•7 years ago
|
||
We were extracting elements from the queue and unnecessarily refcounting them, rather than transferring the owning reference out of the queue and out to the caller.
Attachment #8920158 -
Flags: review?(erahm)
|
||
Updated•7 years ago
|
Attachment #8920158 -
Flags: review?(erahm) → review+
Pushed by nfroyd@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/568b77a84f25 don't copy QueueEntry(ies) when calling LabeledEventQueue::GetEvent; r=erahm
|
|
||
Comment 3•7 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/568b77a84f25
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla58
You need to log in
before you can comment on or make changes to this bug.
Description
•