1411700 - Show that an Extension is controlling the default notifications permission

Status: VERIFIED FIXED

(WebExtensions :: General, enhancement, P5)

Description

[Bob Silverberg [:bsilverberg]]

This is another "Project Jazz" bug that has to do with the fact that a new browserSettings API is going to land, called webNotificationsDisabled. If this is set to `true` by an extension then the default permissions for that profile will be to deny permission to issue web notifications.

I'm not sure exactly how this should be shown in the UI, but it's something that should be covered by Jazz. See [1] for a bit of discussion about this.

[1] https://bugzilla.mozilla.org/show_bug.cgi?id=1364942#c19

Comment 1

[Johann Hofmann [:johannh]]

This should be displayed next to the checkbox that bug 1368744 is adding. See mockups in that bug. :)

Comment 2

[:prathiksha]

Attachment: Bug 1411700 - Show that an Extension is controlling the default notifications permission.

Show that an Extension is controlling the default notifications permission

Comment 3

[:prathiksha]

Attachment: manifest.json

Comment 4

[:prathiksha]

Attachment: test.js

Background script for the test extension.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/225546ee5bd2
Show that an Extension is controlling the default notifications permission. r=flod,johannh

Comment 6

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/225546ee5bd2

Comment 7

[Vlad Jiman]

Will this bug require manual testing? if so please specify some steps to validate or set the 'qe-verify-' flag, thank you

Comment 8

[Luca Greco [:rpl] [:luca] [:lgreco]]

Moving the needinfo to Mark (because he has been the mentor on this bug).

Comment 9

[Bob Silverberg [:bsilverberg]]

Thanks Luca! I was just about to do that myself. :-)

Comment 10

[:prathiksha]

To test -

1. Install an extension that globally overrides the desktop-notification permission or load one manually(the manifest.json and test.js files are attached above) in about:debugging.

2. If you're using the attached test extension, click on the extension's browser action icon in the toolbar to set the override setting to true.

3. Open Preferences > Privacy and Security > Permissions > Settings button(Notifications Permission).

4. You should be able to see a section at the bottom of the settings dialog indicating that an extension is controlling the notifications permission setting.

5. Should be able to disable the extension by clicking the "Disable Extension" button and instructions to re-enable the extension should appear in the same section.

Comment 11

[:prathiksha]

See Comment 10 for steps to validate this change. Thanks!

Comment 12

[Vlad Jiman]

Thank you for the testing steps. I've successfully validated that the Settings is showing the notification using Nightly  	65.0a1 and 64.0b3. Both running on windows 10 x64.

Comment 13

[Vlad Jiman]

Attachment: 2018-10-31_16h52_08.png