1411867 - Linux repacks detected as unofficial builds

Status: RESOLVED FIXED

(Firefox :: New Tab Page, defect)

Description

[Alessio Placitelli [:Dexter]]

While working on some bug, I stumbled upon this [1] line of code that tries to determine whether a build is a local developer build or not:

> const IS_UNOFFICIAL_BUILD = Services.prefs.getStringPref("app.update.channel") === "default";

I think this should be done by checking MOZILLA_OFFICIAL [2] and not the channel. There are some official Linux repacks (and there might be other cases) that leave the channel name as "default" and this could would misinterpret these cases [3].

[1] - http://searchfox.org/mozilla-central/rev/dd47bee6468de7e1221b4d006342ad6b9813d0e5/browser/extensions/activity-stream/lib/ActivityStreamPrefs.jsm#80
[2] - http://searchfox.org/mozilla-central/source/toolkit/modules/AppConstants.jsm#42
[3] - https://sql.telemetry.mozilla.org/queries/47690#table

Comment 1

[Tim Spurway [:tspurway]]

Ed, is this something that should be tracked for 57?

Comment 2

[Ed Lee :Mardak]

I noted in https://github.com/mozilla/activity-stream/issues/3769 that the only pref that relies on this behavior is the telemetry pref (browser.newtabpage.activity-stream.telemetry). So that means we won't get data from these types of repacks.

Dexter, any idea how widespread this might be? E.g., total number of users?

Comment 3

[Alessio Placitelli [:Dexter]]

(In reply to Ed Lee :Mardak from comment #2)
> I noted in https://github.com/mozilla/activity-stream/issues/3769 that the
> only pref that relies on this behavior is the telemetry pref
> (browser.newtabpage.activity-stream.telemetry). So that means we won't get
> data from these types of repacks.
> 
> Dexter, any idea how widespread this might be? E.g., total number of users?

I'm not sure off the top of my head, sorry :( I don't think this is urgent FWIW, but I think it's still worth fixing.

Comment 4

[Alessio Placitelli [:Dexter]]

For example, I'm sure this affects Fedora users (but it doesn't affect Ubuntu users).

Comment 5

[Ed Lee :Mardak]

Fixed by https://github.com/mozilla/activity-stream/pull/3844 to be uplifted via bug 1415812.

Comment 6

[Ed Lee :Mardak]

https://hg.mozilla.org/mozilla-central/rev/b4d1db669c93

Comment 7

[Gerry Chang [:gchang]]

Bug 1415812 has been uplifted to 58. We should not mark 58 fixed.

Comment 8

[Gerry Chang [:gchang]]

Sorry for typo in comment #7. What I meant is bug 1415812 has not been uplift to 58.

Comment 9

[Ed Lee :Mardak]

gchang says this bug has missed 58.0b8. It doesn't have a patch with beta approval flag. Please attach the appropriate patch without install.rdf.in changes and request approval ASAP.

Comment 10

[Andrei Oprea [:andreio]]

Attachment: Bug 1411867 - Linux repacks detected as unofficial builds.

Review commit: https://reviewboard.mozilla.org/r/204298/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/204298/

Comment 11

[Andrei Oprea [:andreio]]

Comment on attachment 8933376 [details]
Bug 1411867 - Linux repacks detected as unofficial builds.

Approval Request Comment
[Feature/Bug causing the regression]: https://github.com/mozilla/activity-stream/commit/59d8e5e1e72d3496535392d2f484b8b413f71ea6
[User impact if declined]: incorrect telemetry data for subset of linux distros
[Is this code covered by automated tests?]: yes
[Has the fix been verified in Nightly?]: yes
[Needs manual test from QE? If yes, steps to reproduce]: no
[List of other uplifts needed for the feature/fix]:
[Is the change risky?]: no
[Why is the change risky/not risky?]: change only affects telemetry 
[String changes made/needed]: no

Comment 12

[Kate Hudson :k88hudson]

Comment on attachment 8933376 [details]
Bug 1411867 - Linux repacks detected as unofficial builds.

https://reviewboard.mozilla.org/r/204298/#review209878

R+

Comment 13

[Gerry Chang [:gchang]]

Comment on attachment 8933376 [details]
Bug 1411867 - Linux repacks detected as unofficial builds.

Fix an incorrect telemetry colletion issue. Beta58+.

Comment 14

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-beta/rev/7fe3a16c32f7