1412064 - Upgrade Earlgrey to 1.12.1

Status: RESOLVED FIXED

(Firefox for iOS :: Build & Test, defect)

Description

[No-Jun Park [:njpark]]

1.12.1 is Xcode 9 compatible.

Comment 1

[No-Jun Park [:njpark]]

Attachment: PR Link

Comment 2

[Isabel Rios[:isabel_rios]]

LGTM but the ClearPrivateDataTest(testClearsHistoryPanel) is failing in BB https://dashboard.buddybuild.com/apps/57bf25c0f096bc01001e21e0/build/59f2edb1c6c5370001a6c41e#tests

It works for me locally, running the test from your branch, but not in BB, I re-run the build just in case it was a timing issue, but got same results. Do you have any idea why? 

We could land this PR to have the EarlGrey updated and open a follow up for the test or fix it here, as you prefer.

Comment 3

[No-Jun Park [:njpark]]

Hmm, I thought upgrading earlgrey might have fixed it - what I've seen locally was that for some reason, it was making tab change to Topsite after going to History tab.  will investigate a bit more.

Comment 4

[No-Jun Park [:njpark]]

I think using the KIFtest avoids this mystery tapping for now.  Isabel, could you take a look again?

Comment 5

[Isabel Rios[:isabel_rios]]

Comment on attachment 8922450 [details] [review]
PR Link

Looks that this is working now. Thanks!

Comment 6

[No-Jun Park [:njpark]]

Merged: https://github.com/mozilla-mobile/firefox-ios/commit/0752259d3d4c8f63c09373f240d5f52872626e84

Comment 7

[Stefan Arentz | :st3fan | ⏰ EST | he/him]

Uplifted to v10.x