Closed
Bug 1412141
Opened 7 years ago
Closed 7 years ago
Correctly forward change sources when updating keywords
Categories
(Toolkit :: Places, enhancement)
Toolkit
Places
Tracking
()
RESOLVED
FIXED
mozilla58
| Tracking | Status | |
|---|---|---|
| firefox58 | --- | fixed |
People
(Reporter: lina, Assigned: lina)
References
Details
Attachments
(1 file)
Currently, Sync uses the public `PlacesUtils.keywords` API; however, the new Sync bookmark buffer in bug 1305563 writes to `moz_keywords` directly, then fires `onItemChanged` observer notifications to update the cache. Forwarding the change source lets us avoid doing unnecessary work when updating synced keywords.
| Comment hidden (mozreview-request) |
|
||
Comment 2•7 years ago
|
||
| mozreview-review | ||
Comment on attachment 8922569 [details] Bug 1412141 - Correctly forward change sources when updating keywords. https://reviewboard.mozilla.org/r/193668/#review199032
Attachment #8922569 -
Flags: review?(mak77) → review+
Pushed by kcambridge@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/98e8d4a67e67 Correctly forward change sources when updating keywords. r=mak
|
||
Comment 4•7 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/98e8d4a67e67
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
status-firefox58:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla58
You need to log in
before you can comment on or make changes to this bug.
Description
•