Open
Bug 141265
Opened 22 years ago
Updated 2 years ago
FrameManager::ReparentStyleContext should share more code with ReResolveStyleContext
Categories
(Core :: CSS Parsing and Computation, defect, P5)
Core
CSS Parsing and Computation
Tracking
()
NEW
Future
People
(Reporter: dbaron, Unassigned)
References
Details
(Whiteboard: [whitebox])
FrameManager::ReParentStyleContext has all the bugs that FrameManager::ReResolveStyleContext used to. I think nobody uses it, so it can be removed. If not, it needs all the fixes that ReResolveStyleContext has (thanks to the sibling sharing optimization -- otherwise it would be much easier).
Reporter | ||
Updated•22 years ago
|
Status: NEW → ASSIGNED
Priority: -- → P1
Target Milestone: --- → mozilla1.1beta
Comment 1•22 years ago
|
||
cc'ing myself
Reporter | ||
Updated•22 years ago
|
Target Milestone: mozilla1.1beta → mozilla1.2alpha
Reporter | ||
Updated•22 years ago
|
Target Milestone: mozilla1.2alpha → Future
Updated•22 years ago
|
Whiteboard: [dev notes]
Updated•22 years ago
|
Whiteboard: [dev notes] → [whitebox]
Reporter | ||
Comment 2•22 years ago
|
||
I think the best way to fix this would be to ensure that all the callers of ReParentStyleContext are doing things accounted for by GetParentStyleContextFrame and then make ReParentStyleContext call ReResolveStyleContext with a special parameter saying not to find a new rule node (and perhaps not to build a change list).
Reporter | ||
Comment 3•22 years ago
|
||
Er, never mind the previous comment. But the two could use a single helper function to do most of the work.
Reporter | ||
Comment 4•17 years ago
|
||
This is mostly done by bug 322348, although we could use more code sharing. (Or is that not possible?)
Assignee: dbaron → nobody
Status: ASSIGNED → NEW
QA Contact: ian → style-system
Summary: FrameManager::ReParentStyleContext should be removed or fixed → FrameManager::ReParentStyleContext should share more code
Reporter | ||
Updated•13 years ago
|
Summary: FrameManager::ReParentStyleContext should share more code → FrameManager::ReparentStyleContext should share more code with ReResolveStyleContext
Reporter | ||
Updated•13 years ago
|
Priority: P1 → P5
Updated•2 years ago
|
Severity: normal → S3
You need to log in
before you can comment on or make changes to this bug.
Description
•