1412789 - Fix slider position of the tracking protection toggle button in RTL locales

Status: VERIFIED FIXED

(Firefox :: Private Browsing, defect, P3)

Description

[magicp]

Attachment: tracking-protection-toggle-button-in-rtl.png

Steps to reproduce:
1. Start Firefox in RTL locales.
2. Open a new private window.
3. Check the tracking protection toggle button

Actual Results:
checked slider position is wrong.

Expected Results:
[aboutprivatebrowsing.css]
.toggle:checked + .toggle-btn:dir(rtl)::after {
  left: auto;
  right: 16px; <= should be 21px
}

Comment 1

[Johann Hofmann [:johannh]]

The fix for this problem is described in comment 0. If you're not on an rtl language, you can just paste

document.body.dir = "rtl"

into the console on about:privatebrowsing to flip it.

The line to change is here: https://searchfox.org/mozilla-central/rev/af86a58b157fbed26b0e86fcd81f1b421e80e60a/browser/themes/shared/privatebrowsing/aboutPrivateBrowsing.css#161

Comment 2

[Tim Nguyen :ntim]

If offset-inline-start is enabled by default, we could also use that.

Comment 3

[Luke Crouch [:groovecoder]]

Attachment: Bug 1412789 - fix tracking protection slider position in rtl

Use logical properties for offset and float to avoid rtl-specific rules.

Note: background-position and transition property don't support logical
properties, so those rtl-specific rules must be kept for now.

Review commit: https://reviewboard.mozilla.org/r/200800/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/200800/

Comment 4

[Johann Hofmann [:johannh]]

Comment on attachment 8929526 [details]
Bug 1412789 - fix tracking protection slider position in rtl

https://reviewboard.mozilla.org/r/200800/#review206136

Looks perfect, thank you!

::: commit-message-45715:1
(Diff revision 1)
> +fix tracking protection slider position in rtl (bug 1412789) r?johannh

Nit: The preferred commit message style is

Bug 1412789 - Fix tracking protection slider position in rtl. r?johannh

Comment 5

[Luke Crouch [:groovecoder]]

Comment on attachment 8929526 [details]
Bug 1412789 - fix tracking protection slider position in rtl

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/200800/diff/1-2/

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/9ee6a53be307
fix tracking protection slider position in rtl r=johannh

Comment 7

[Eliza Balazs [:ebalazs_]]

https://hg.mozilla.org/mozilla-central/rev/9ee6a53be307

Comment 8

[Ryan VanderMeulen [:RyanVM]]

Please request Beta approval on this when you get a chance.

Comment 9

[roxleitan]

Reproduced the issue on Nightly (2017-10-31) on Ubuntu 16.04 x64.

Verified fixed on latest Nightly (2017-12-05) on Windows 10 x64, Ubuntu 16.04 x64 and Mac OS X 10.12.