1413448 - Browser hangs in about:telemetry is not readable

Status: RESOLVED FIXED

(Toolkit :: Telemetry, defect, P1)

Description

[61.1p57]

Attachment: screenshot.png

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:58.0) Gecko/20100101 Firefox/58.0
Build ID: 20171030103605

Steps to reproduce:

Open about:telemetry, find a ping that has records in "Browser Hangs" section


Actual results:

The 'Sorry! There is currently no data available in “Browser Hangs”' prompt insists on the screen, making the records hard to read.


Expected results:

The prompt should go away if there is data available to display.

Comment 1

[Chris H-C :chutten]

My guess is that "Browser Hangs" is another section that should be on the search blacklist (a la bug 1396836)

Comment 2

[Georg Fritzsche [:gfritzsche]]

Chris, can this be a mentored bug?

Comment 3

[Chris H-C :chutten]

It certainly can be!

This bug involves: 

0) Volunteering on this bug to help out (at which point I will assign it to you)
1) downloading and building the Firefox source,
2) editing toolkit/content/aboutTelemetry.js to add the chrome-hangs section to the search blacklist (on or around this line https://searchfox.org/mozilla-central/source/toolkit/content/aboutTelemetry.js#1285),
3) then rebuilding and testing that the search bar and "no search results" bear don't show on the Browser Hangs tab any longer.
4) Formatting a commit with a useful commit message, marking me as a reviewer

Comment 4

[61.1p57]

Although I can't verify it myself since I recently moved back to Beta, but IIRC the "Browser Hangs" section is acutally searchable. Do we really want to disable searching altogether just because an error message appeared unintentionally?

BTW, I suppose this also affects the "Late Writes" section as it also shows the "no data available" message

Comment 5

[Chris H-C :chutten]

You're probably right. It's been a while since I've seen data in Late Writes or Browser Hangs so I'm not 100% sure what it's supposed to look like.

Maybe it would be better to hide the "Fetch function names for stacks" link in Browser Hangs,Late Writes when there is no data to display.

Comment 6

[mandercs3]

Hi, I can make a start on this bug ASAP.

Comment 7

[Chris H-C :chutten]

Wonderful! As mentioned in comment 5, the new step 2 is to ensure the "Fetch function names for stacks" links do not appear when there are no hangs or late writes. That should take care of the overlapping display we're seeing in the attached screenshot.

Please let me know if you have any questions!

Comment 8

[Chris H-C :chutten]

Are you still working on this, or should I unassign you from the bug? No worries if you're busy! There are always more bugs for when you have a moment in the future :)

Comment 9

[Jeremy Lempereur [:o0ignition0o]]

Hey there :) I don't know if the bug is still being worked on, but I would love to work on it if it's available ! :)

Comment 10

[Jeremy Lempereur [:o0ignition0o]]

As it turns out, the search functionality is looking for a table ( https://searchfox.org/mozilla-central/source/toolkit/content/aboutTelemetry.js#1417 ) in order to proceed.

I think the easiest thing to handle this for now would be to disable search altogether in the Late Writes and Browser Hangs pages (I guess it wasn't searchable anyway).

A nice followup would be to format the Late Writes and Browser Hangs in a nice table, and restore a search functionality.

I'll prepare a patch to add Late Writes and Browser Hangs to the search blacklist, and I can followup on this someone can point me to a place where I can find browser hangs and late writes JSON objects to reproduce the output (I used a couple of arrays with random strings to reproduce the bug http://ibb.co/erdsUw ) 

I'm about to submit a patch with two distinct commits (one for Late Writes and one for Browser Hangs)

Oh and a Happy new year ! :)

Comment 11

[Jeremy Lempereur [:o0ignition0o]]

Attachment: Bug 1413448 - Fix about:telemetry "no data available" overlay in the Browser Hangs section.

The search feature in the Browser Hangs section does not work, and a message claiming "Sorry there's no data available in "Browser Hangs" hindered the view of the data. I added the chrome-hangs-section to the search blacklist.

Review commit: https://reviewboard.mozilla.org/r/209686/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/209686/

Comment 12

[Jeremy Lempereur [:o0ignition0o]]

Attachment: Bug 1413448 - Fix about:telemetry "no data available" overlay in the Late Writes section.

The search feature in the Late Writes section does not work, and a message claiming "Sorry there's no data available in "Late Writes" hindered the view of the data. I added the late-writes-section to the search blacklist.

Review commit: https://reviewboard.mozilla.org/r/209688/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/209688/

Comment 13

[Chris H-C :chutten]

Comment on attachment 8939259 [details]
Bug 1413448 - Fix about:telemetry "no data available" overlay in the Late Writes section.

https://reviewboard.mozilla.org/r/209688/#review215456

Looks good to me!

Comment 14

[Chris H-C :chutten]

Comment on attachment 8939258 [details]
Bug 1413448 - Fix about:telemetry "no data available" overlay in the Browser Hangs section.

https://reviewboard.mozilla.org/r/209686/#review215458

Looks good to me!

Comment 15

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/b3af16adba66
Fix about:telemetry "no data available" overlay in the Browser Hangs section. r=chutten
https://hg.mozilla.org/integration/autoland/rev/d4e1ce460135
Fix about:telemetry "no data available" overlay in the Late Writes section. r=chutten

Comment 16

[Chris H-C :chutten]

I've sent these to autoland. Thanks for your contribution!

As for example late writes and browser hangs, there's some documentation on the formats available in our in-tree docs: https://firefox-source-docs.mozilla.org/toolkit/components/telemetry/telemetry/data/main-ping.html#chromehangs

They're some of the less-frequently-used parts of the data, so I wouldn't worry too much about them being searchable.

Comment 17

[Andrei Ciure[:aciure]]

https://hg.mozilla.org/mozilla-central/rev/b3af16adba66
https://hg.mozilla.org/mozilla-central/rev/d4e1ce460135