Closed
Bug 1413900
Opened 7 years ago
Closed 7 years ago
Remove unused JS capability macros
Categories
(Core :: JavaScript Engine, enhancement)
Core
JavaScript Engine
Tracking
()
RESOLVED
FIXED
mozilla58
| Tracking | Status | |
|---|---|---|
| firefox58 | --- | fixed |
People
(Reporter: evilpie, Assigned: evilpie)
Details
Attachments
(1 file)
|
1.39 KB,
patch
|
arai
:
review+
|
Details | Diff | Splinter Review |
I don't see any value in keeping those around.
Attachment #8924527 -
Flags: review?(arai.unmht)
|
||
Comment 1•7 years ago
|
||
Comment on attachment 8924527 [details] [diff] [review] Remove unused JS capability macros Review of attachment 8924527 [details] [diff] [review]: ----------------------------------------------------------------- r+ with one fix. ::: js/src/jsversion.h @@ -20,4 @@ > #define JS_HAS_FOR_EACH_IN 1 /* has for each (lhs in iterable) */ > -#define JS_HAS_GENERATORS 1 /* (no longer used) */ > -#define JS_HAS_BLOCK_SCOPE 1 /* (no longer used) */ > -#define JS_HAS_DESTRUCTURING 2 /* (no longer used) */ JS_HAS_DESTRUCTURING is used just below. please remove JS_HAS_DESTRUCTURING_SHORTHAND as well. @@ -25,4 @@ > #define JS_HAS_EXPR_CLOSURES 1 /* has function (formals) listexpr */ > > /* (no longer used) */ > #define JS_HAS_NEW_GLOBAL_OBJECT 1 this also can be removed.
Attachment #8924527 -
Flags: review?(arai.unmht) → review+
Pushed by evilpies@gmail.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/c1576d8e9cb7 Remove unused JS capability macros. r=arai
|
||
Comment 3•7 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/c1576d8e9cb7
Status: NEW → RESOLVED
Closed: 7 years ago
status-firefox58:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla58
You need to log in
before you can comment on or make changes to this bug.
Description
•