Closed
Bug 1414340
Opened 7 years ago
Closed 7 years ago
Remove ES draft array/generator comprehensions
Categories
(Core :: JavaScript Engine, enhancement, P3)
Core
JavaScript Engine
Tracking
()
RESOLVED
FIXED
mozilla58
People
(Reporter: evilpie, Assigned: jandem)
References
(Blocks 1 open bug)
Details
(Keywords: dev-doc-complete, site-compat)
Attachments
(2 files, 1 obsolete file)
|
6.54 KB,
patch
|
mossop
:
review+
|
Details | Diff | Splinter Review |
|
166.58 KB,
patch
|
evilpie
:
review+
|
Details | Diff | Splinter Review |
The "new" array/generator comprehension syntax doesn't seem to have any active proposals and is not implemented by another browser.
|
||
Updated•7 years ago
|
|
Assignee | |
Comment 1•7 years ago
|
||
Passes shell tests.
|
|
Assignee | |
Comment 2•7 years ago
|
||
|
|
Assignee | |
Comment 3•7 years ago
|
||
Attachment #8926351 -
Attachment is obsolete: true
Attachment #8926433 -
Flags: review?(evilpies)
|
||
Updated•7 years ago
|
Keywords: dev-doc-needed,
site-compat
|
Reporter | |
Updated•7 years ago
|
Attachment #8926433 -
Flags: review?(evilpies) → review+
|
|
Reporter | |
Comment 4•7 years ago
|
||
Comment on attachment 8926432 [details] [diff] [review] Part 1 - Fix Gecko code Review of attachment 8926432 [details] [diff] [review]: ----------------------------------------------------------------- Redirecting. I wasn't sure how other people feel about the function* syntax. I thought it's a bit magically, but maybe I am not used to new-JS yet.
Attachment #8926432 -
Flags: review?(evilpies) → review?(dtownsend)
|
||
Comment 5•7 years ago
|
||
Comment on attachment 8926432 [details] [diff] [review] Part 1 - Fix Gecko code Review of attachment 8926432 [details] [diff] [review]: ----------------------------------------------------------------- Could have sworn that we did this already
Attachment #8926432 -
Flags: review?(dtownsend) → review+
Pushed by jandemooij@gmail.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/71e5015934c2 part 1 - Remove non-standard array/generator comprehensions from browser code. r=mossop https://hg.mozilla.org/integration/mozilla-inbound/rev/67fe0ac257b8 part 2 - Remove array/generator comprehensions from SpiderMonkey. r=evilpie
|
|
||
Comment 7•7 years ago
|
||
Posted the site compatibility note: https://www.fxsitecompat.com/en-CA/docs/2017/array-generator-comprehension-support-has-been-removed/
|
||
Comment 8•7 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/71e5015934c2 https://hg.mozilla.org/mozilla-central/rev/67fe0ac257b8
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla58
|
||
Comment 9•7 years ago
|
||
Developer release notes for 58 https://developer.mozilla.org/en-US/Firefox/Releases/58#JavaScript_2 Reference pages updated https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Operators/Array_comprehensions https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Operators/Generator_comprehensions Compat data update https://github.com/mdn/browser-compat-data/pull/664
Keywords: dev-doc-needed → dev-doc-complete
You need to log in
before you can comment on or make changes to this bug.
Description
•