1414421 - Change MSCOM diagnostic asserts to fire only on Nightly

Status: RESOLVED FIXED

(Core :: IPC: MSCOM, defect)

Description

[(No longer employed by Mozilla) Aaron Klotz]

Let's prevent these from firing on dev edition.

Comment 1

[(No longer employed by Mozilla) Aaron Klotz]

Attachment: Patch

Comment 2

[(No longer employed by Mozilla) Aaron Klotz]

https://hg.mozilla.org/integration/mozilla-inbound/rev/08e8c61d3c5a85a9fae9f993092133dbe904abc2
Bug 1414421: Change some diagnostic asserts in mscom to stop firing on dev edition; r=Jamie

Comment 3

[Dorel Luca [:dluca]]

https://hg.mozilla.org/mozilla-central/rev/08e8c61d3c5a

Comment 4

[(No longer employed by Mozilla) Aaron Klotz]

Comment on attachment 8933083 [details] [diff] [review]
Patch

Approval Request Comment
[Feature/Bug causing the regression]: a11y+e10s
[User impact if declined]: Unnecessary crashing on dev edition
[Is this code covered by automated tests?]: Yes
[Has the fix been verified in Nightly?]: No, because this fix does not affect Nightly
[Needs manual test from QE? If yes, steps to reproduce]: No
[List of other uplifts needed for the feature/fix]: None
[Is the change risky?]: No
[Why is the change risky/not risky?]: It makes Dev Edition act the same way as Beta and Release
[String changes made/needed]: None

Comment 5

[Gerry Chang [:gchang]]

Comment on attachment 8933083 [details] [diff] [review]
Patch

Avoid unnecessary crashing on dev edition. Beta58+.

Comment 6

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

Please provide a patch for beta. At least bug 1402519 prevents the central patch from applying on beta. Thank you.

Comment 7

[(No longer employed by Mozilla) Aaron Klotz]

https://hg.mozilla.org/releases/mozilla-beta/rev/64ea10c053272a0f0e208dfada147ab9d4134379