Open
Bug 1414435
Opened 7 years ago
Updated 2 years ago
Remove `_defaultSort` from the bookmarks engine
Categories
(Firefox :: Sync, enhancement, P3)
Firefox
Sync
Tracking
()
NEW
People
(Reporter: lina, Unassigned)
References
Details
We only set `_defaultSort` to "index" in the bookmarks engine (https://searchfox.org/mozilla-central/rev/af86a58b157fbed26b0e86fcd81f1b421e80e60a/services/sync/modules/engines/bookmarks.js#287), to fetch and apply toolbar bookmarks, folders, and frecent sites first. Once bug 1305563 lands, the order of bookmark records won't matter, since we'll buffer everything before applying. Ryan also noted in bug 1368951, comment 4 that the Python server doesn't index on `sortindex`, so we might get a small efficiency boost from removing this and letting the server use whatever order it wants.
Updated•7 years ago
|
Priority: -- → P3
Comment 1•6 years ago
|
||
Hi @Kit. I'd like to be assigned to solve this bug. :) what exactly I need to do in this? replacement of 'defaultSort' with 'index'?
Flags: needinfo?(kit)
Reporter | ||
Comment 2•6 years ago
|
||
Hi Manish, thanks for your interest! This isn't quite ready to be worked on yet, because the old bookmarks engine still uses `_defaultSort: "index"`. We can remove `_defaultSort` after bug 1449730.
Updated•2 years ago
|
Severity: normal → S3
You need to log in
before you can comment on or make changes to this bug.
Description
•