Closed
Bug 1414546
Opened 7 years ago
Closed 7 years ago
No longer treat "yield" as keyword in js>=1.7
Categories
(Core :: JavaScript Engine, enhancement)
Core
JavaScript Engine
Tracking
()
RESOLVED
FIXED
mozilla58
| Tracking | Status | |
|---|---|---|
| firefox58 | --- | fixed |
People
(Reporter: anba, Assigned: anba)
Details
Attachments
(1 file)
|
6.33 KB,
patch
|
jandem
:
review+
|
Details | Diff | Splinter Review |
Leftover from bug 1083482: The |versionNumber() >= JSVERSION_1_7| condition in [1] needs to be removed. [1] https://searchfox.org/mozilla-central/rev/af86a58b157fbed26b0e86fcd81f1b421e80e60a/js/src/frontend/Parser.cpp#9011
|
Assignee | |
Comment 1•7 years ago
|
||
We no longer need to handle "yield" as a keyword in js>=1.7 now that legacy generators are gone.
Assignee: nobody → andrebargull
Status: NEW → ASSIGNED
Attachment #8925925 -
Flags: review?(jdemooij)
|
||
Comment 2•7 years ago
|
||
Comment on attachment 8925925 [details] [diff] [review] bug1414546.patch Review of attachment 8925925 [details] [diff] [review]: ----------------------------------------------------------------- LGTM, thanks!
Attachment #8925925 -
Flags: review?(jdemooij) → review+
|
|
Assignee | |
Comment 3•7 years ago
|
||
Try: https://treeherder.mozilla.org/#/jobs?repo=try&revision=db9c9dc22adee889475531fce7cb5e134004a68c
Keywords: checkin-needed
Pushed by ryanvm@gmail.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/e12503415ea5 Don't treat "yield" as a keyword in JS1.7. r=jandem
Keywords: checkin-needed
|
||
Comment 5•7 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/e12503415ea5
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla58
You need to log in
before you can comment on or make changes to this bug.
Description
•