1414747 - secport.c fix signed / unsigned mismatch

Status: RESOLVED FIXED

(NSS :: Libraries, defect)

Description

[jbonnafo]

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:56.0) Gecko/20100101 Firefox/56.0
Build ID: 20171024165158

Steps to reproduce:

I have compiled code using Visual Studio 2017 and the compiler reports a warning about signed / unsigned mismatch


Actual results:

Compiler reported the following warning:
security/nss/lib/util/secport.c:793 [C4018] '<': signed/unsigned mismatch


Expected results:

Code should have compiled without any warning.

Comment 1

[Phabricator Automation]

Comment on attachment 8925447 [details]
Bug 1414747 - secport.c fix signed / unsigned mismatch

Tim Taubert [:ttaubert] has approved the revision.

https://phabricator.services.mozilla.com/D192#4820

Comment 2

[Tim Taubert [:ttaubert] (inactive)]

BTW, for the next time, please submit a patch against the NSS repository [1]. Firefox just uses a copy of NSS but we usually work on the upstream repo. Thanks!

[1] https://hg.mozilla.org/projects/nss

Comment 3

[Tim Taubert [:ttaubert] (inactive)]

https://hg.mozilla.org/projects/nss/rev/c710811a5cc7

Comment 4

[jbonnafo]

Hello,

Thanks for the review and comment. Does it mean i have to do a dedicated pull request for code changes on NSS ?

Thanks,

Comment 5

[Tim Taubert [:ttaubert] (inactive)]

You basically should have a separate checkout of NSS (without the surrounding Firefox code) and then call "arc diff" in there.

Comment 6

[Phabricator Automation]

Comment on attachment 8925447 [details]
Bug 1414747 - secport.c fix signed / unsigned mismatch

Tim Taubert [:ttaubert] has been removed from the revision.

https://phabricator.services.mozilla.com/D192