1414838 - Stop button no longer appears immediately after starting a navigation

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Jan Henning [:JanH]]

Previously, the stop button appeared immediately after clicking a link, together with the progress bar showing up and indicating minimal progress.

Currently, the progress bar appears immediately just a before, but the stop button only shows up after the navigation got as far as a location change.
This means that at the moment you can no longer cancel a page load before we've already navigated away from the old page.

Comment 1

[Jan Henning [:JanH]]

Out of https://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=892c8916ba32b7733e06bfbfdd4083ffae3ca028&tochange=2306e153fba9ca55726ffcce889eaca7a479c29f it's almost certainly bug 1366672.

Comment 2

[Jan Henning [:JanH]]

[Tracking Requested - why for this release]: User can no longer abort a page load until it gets as far as "location change".

Comment 3

[Jan Henning [:JanH]]

Attachment: Bug 1414838 - Show stop button again as soon as page loading starts.

As of bug 1366672, case START no longer falls through in order to allow for a
different behaviour of the progress indicator, however we still need to add
UpdateFlags.PROGRESS, so that the stop button shows up as soon as a page starts
loading.

Review commit: https://reviewboard.mozilla.org/r/196744/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/196744/

Comment 4

[Liz Henry (:lizzard) (relman/hg->git project)]

Tracking for 57 for now, but since this is marked fix-optional it won't show up on some of release managment's (and other) queries. 
If you land this on m-c and the tests pass, and you still think we need to fix it for 57, please request uplift.

Comment 5

[Jan Henning [:JanH]]

Marking it as affected for now then.

Comment 6

[Nevin Chen(Not active on Bugzilla)]

Comment on attachment 8925633 [details]
Bug 1414838 - Show stop button again as soon as page loading starts.

https://reviewboard.mozilla.org/r/196744/#review202052

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/e46ec8edd9ba
Show stop button again as soon as page loading starts. r=nechen

Comment 8

[Andreea Pavel [:apavel]]

https://hg.mozilla.org/mozilla-central/rev/e46ec8edd9ba

Comment 9

[Jan Henning [:JanH]]

Comment on attachment 8925633 [details]
Bug 1414838 - Show stop button again as soon as page loading starts.

Approval Request Comment
[Feature/Bug causing the regression]: Bug 1366672
[User impact if declined]: After starting a page load, users cannot cancel it again until the load gets as far as locationchanges (or else eventually times out).
[Is this code covered by automated tests?]: No.
[Has the fix been verified in Nightly?]: Verified locally.
[Needs manual test from QE? If yes, steps to reproduce]: No.
[List of other uplifts needed for the feature/fix]: none
[Is the change risky?]: No.
[Why is the change risky/not risky?]: This simply restores the old behaviour of updating the toolbar state on starting a page load as well.
[String changes made/needed]:

Comment 10

[Julien Cristau [:jcristau]]

Comment on attachment 8925633 [details]
Bug 1414838 - Show stop button again as soon as page loading starts.

57 is on m-r now.

Comment 11

[Julien Cristau [:jcristau]]

Ioana, can you verify this fix in nightly?

Comment 12

[u549602]

Verified as fixed on the latest Beta (58.0b3/build 4) and the latest Nightly (59.0a1 / 2017-11-14)
This issue was tested on a Pixel C (Android 8.0)

Comment 13

[Sylvestre Ledru [:Sylvestre]]

Comment on attachment 8925633 [details]
Bug 1414838 - Show stop button again as soon as page loading starts.

Fix a recent regression and didn't cause any regression for now, taking it.

Comment 14

[Sylvestre Ledru [:Sylvestre]]

https://hg.mozilla.org/releases/mozilla-release/rev/665de5ab92fccb052ee1625e1df196c8a9d082d0

Comment 15

[Oana Horvath [:ohorvath]]

Verified as fixed on RC 57.0.1.
Device: Samsung Galaxy Tab 3 (Android 7.0)