1416085 - Use Span<> to replace low level pointer arithmetic in MediaCacheStream::Read()

Status: RESOLVED FIXED

(Core :: Audio/Video: Playback, defect, P3)

Comment 1

[JW Wang [:jwwang] [:jw_wang]]

Attachment: Bug 1416085 - use Span<> to replace low level pointer arithmetic in Read().

Review commit: https://reviewboard.mozilla.org/r/198970/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/198970/

Comment 2

[Benjamin Chen [:bechen]]

Comment on attachment 8927692 [details]
Bug 1416085 - use Span<> to replace low level pointer arithmetic in Read().

https://reviewboard.mozilla.org/r/198970/#review204028

Comment 3

[Gerald Squelart (he/him) (not at Mozilla since 2022-09-15)]

Comment on attachment 8927692 [details]
Bug 1416085 - use Span<> to replace low level pointer arithmetic in Read().

https://reviewboard.mozilla.org/r/198970/#review204256

::: dom/media/MediaCache.cpp:2568
(Diff revision 1)
> +    }
>  
> -      // See if the data is available in the partial cache block of any
> -      // stream reading this resource. We need to do this in case there is
> -      // another stream with this resource that has all the data to the end of
> -      // the stream but the data doesn't end on a block boundary.
> +    // See if we can use the data in the partial block of any stream reading
> +    // this resource. Note we use the partial block only when it is completed,
> +    // that is reaching EOS.
> +    bool foundDataInPartialBLock = false;

'foundDataInPartialBLock' -> 'foundDataInPartialBlock' ('L' in 'Block' should not be capitalized)

::: dom/media/MediaCache.cpp:2587
(Diff revision 1)
> -        // Break for we've reached EOS and have nothing more to read.
> -        break;
> +      break;
> -      }
> +    }
>  
> -      if (mStreamOffset != streamOffset) {
> +    if (mStreamOffset != streamOffset) {
> -        // Updat mStreamOffset before we drop the lock. We need to run
> +      // Updat mStreamOffset before we drop the lock. We need to run

'Updat' -> 'Update' (mis-fix of a recent nit!)

Comment 4

[JW Wang [:jwwang] [:jw_wang]]

Thanks for the reviews!

Comment 5

[JW Wang [:jwwang] [:jw_wang]]

Comment on attachment 8927692 [details]
Bug 1416085 - use Span<> to replace low level pointer arithmetic in Read().

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/198970/diff/1-2/

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/05f87748526f
use Span<> to replace low level pointer arithmetic in Read(). r=bechen,gerald

Comment 7

[Cristina Coroiu [:ccoroiu]]

https://hg.mozilla.org/mozilla-central/rev/05f87748526f