Closed Bug 1416483 Opened 7 years ago Closed 7 years ago

Remove the "control-item" binding and copy the only property ("value") onto its 3 extended bindings

Categories

(Toolkit :: UI Widgets, task, P5)

Product:
Toolkit
Component:
UI Widgets
Type:
task

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla59
Tracking Flags:
Tracking Status
firefox57 --- wontfix
firefox58 --- wontfix
firefox59 --- fixed

People

(Reporter: bgrins, Assigned: u605551)

References

Details

(Whiteboard: [xbl-flatten-inheritance][xbl-available])

Attachments

(1 file, 1 obsolete file)

inheritance.patch
3.53 KB, patch
u605551
: review+
Details | Diff | Splinter Review 
There's a binding "control-item" that defines a single property ("value") that maps back to an attribute. This can be copied into the 3 bindings that extend it and the binding can be removed.

https://dxr.mozilla.org/mozilla-central/rev/2535bad09d720e71a982f3f70dd6925f66ab8ec7/toolkit/content/widgets/general.xml#60-65

Inherited bindings (https://dxr.mozilla.org/mozilla-central/search?q=extends+control-item&redirect=false):
- menuitem-base
- radio
- tab
Whiteboard: [xbl-flatten-inheritance] → [xbl-flatten-inheritance][xbl-available]
Copied property "value" to menuitem-base, radio, and tab; set their base to be basetext and removed control-item.
Attachment #8929718 - Flags: review?(enndeakin)
Assignee: nobody → 86ecce74
Status: NEW → ASSIGNED
Attachment #8929718 - Flags: review?(enndeakin) → review+
Could you update the commit message on your patch to include the bug number and the reviewer, as per https://developer.mozilla.org/en-US/docs/Mercurial/Using_Mercurial#Commit_Message_Conventions? Something like:

Bug 1416483 - Remove control-item binding and copy the value property onto its children; r=enndeakin

You can then reupload it with an r+ since it's already gotten the review
Flags: needinfo?(86ecce74)

        Attachment #8929718 -
        Attachment is obsolete: true
Flags: needinfo?(86ecce74)

        Attachment #8930581 -
        Flags: review+

    
    

    
  
Try push looks good, marking for checkin
Keywords: checkin-needed

    
    

    
  
86ecce74, thanks for helping with these! There are a couple more similar bugs available if you are interested in taking them: https://mzl.la/2AyTxCG

    
    

    
  
Pushed by ryanvm@gmail.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/3c44cbc57220
Remove control-item binding and copy the value property onto its children. r=enndeakin
Keywords: checkin-needed

    
  

          status-firefox57:
          --- → wontfix

          status-firefox58:
          --- → wontfix

          status-firefox59:
          --- → fix-optional
Priority: -- → P5

    
    

    
  
https://hg.mozilla.org/mozilla-central/rev/3c44cbc57220
Status: ASSIGNED → RESOLVED
Closed: 7 years ago

          status-firefox59:
          fix-optional → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla59

    
  
Type: enhancement → task

          You need to log in
          before you can comment on or make changes to this bug.
        






  

    
  







  

    

      
Attachment

      

      
      
      
      
    

    

      

        

          

            
General

            

              Creator: 



            

            
Created: 

            
Updated: 

            
Size: