Entering characters with character/accent marks on macOS doesn't remove the autofilled selected part
Categories
(Firefox :: Address Bar, defect, P3)
Tracking
()
People
(Reporter: matija, Assigned: mseibert)
References
(Regressed 1 open bug)
Details
(Keywords: papercut, Whiteboard: [fxsearch][snt-scrubbed][snt-papercut])
Attachments
(4 files)
User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.13; rv:57.0) Gecko/20100101 Firefox/57.0 Build ID: 20171112125346 Steps to reproduce: OS: macOS, with turned on accent menu (should be on by default, I believe) Pre-requisite: have some history entries in Firefox When typing inside the address bar, use the OSX accent menu by holding a key and select an accented letter (e.g. č, ž, é). Actual results: What happens is Firefox uses the first history entry of the non-accented letter and replaces its first character with the accented letter. Expected results: Either a history entry with the correct accented letter should appear (say a unicode domain, if one is in history) or no address should be highlighted but rather just a suggested search engine query.
Updated•7 years ago
|
Comment 1•7 years ago
|
||
I'm sorry, I'm not sure I understand the bug looking at the screenshot. What's in the first suggestion is not in your history, the Address Bar just assumes what you typed looks like a domain and tells you what will happen if you confirm what's currently typed in the url bar. since in the urlbar you typed "čircleci.com/", it tells you if you confirm that you'll end on that page (likely a 404, but the Address Bar can't know). It's possible I'm misunderstanding your report though, if so maybe you could rephrase it for me.
Reporter | ||
Comment 3•7 years ago
|
||
Hi, I included a video above ( https://bug1416881.bmoattachments.org/attachment.cgi?id=8929065 ). I hope this makes it more clear. The way I see it, once I select the letter "č" (or any other accented letter) from OSX's accent menu, the Firefox address bar should reload. Instead, what happens is Firefox automatically replaces only the first letter. Apart from not being intuitive, this also makes it difficult to use the default search engine via address bar if your keyword starts with an accented letter.
Reporter | ||
Comment 4•7 years ago
|
||
For example, here's a video of what would happen if someone wanted to do a search directly from the address bar for "école" on OSX. Instead of modifying a history URL that begins with e (and chaning it into é but retaining the rest of the string), it would be more intuitive if after entering the accented letter, the input text for reloaded and only contained that letter.
Comment 5•7 years ago
|
||
Thank you, the videos help a lot. In pratice, when you type the normal letter, autofill kicks in and adds the autofilled part. When you select the different letter, the autofilled part should be removed, instead it gets unselected. If we can detect the event, clearing the autofilled part should be easy.
Updated•4 years ago
|
Updated•2 years ago
|
Updated•2 years ago
|
Updated•2 years ago
|
Comment 6•2 years ago
•
|
||
the autofilled part should indeed be removed when the first letter changes.
We reproduced this on MacOS by enabling the accented menu option and in an empty urlbar holding down a letter that would normally cause autofill to activate.
We're not sure which events are sent whe nthis happens, so we don't know if we can detect it. Maybe "composition" events are fired?
Updated•2 years ago
|
Comment 7•2 years ago
|
||
We investigated this today as part of a live coding session and we found that compositionstart
is not fired in this case. The next thing I want to investigate is whether a second input
event is fired when the "c" char changes to a "č". I'm guessing one is, and if so we can probably use it as a cue to inspect whether the autofill is still valid.
Updated•2 years ago
|
Comment 8•2 years ago
|
||
Stephanie raised a great point: After the "c" changes to "č", ideally anything that starts with "č" and that should be autofilled would be autofilled at that point. So not only should the old autofill be cleared, but any new autofill should happen. However, if I'm not mistaken, currently nothing can be autofilled with "č" due to bug 1566151, which I marked as a see-also.
Updated•2 years ago
|
Updated•2 years ago
|
Assignee | ||
Updated•10 months ago
|
Assignee | ||
Comment 10•10 months ago
|
||
Comment 11•9 months ago
|
||
Pushed by mak77@bonardo.net: https://hg.mozilla.org/integration/autoland/rev/498b4ed438a3 Entering characters with character/accent marks on macOS doesn't remove the autofilled selected part.r=mak
Assignee | ||
Updated•9 months ago
|
Comment 12•9 months ago
|
||
bugherder |
Updated•9 months ago
|
Comment 13•8 months ago
|
||
Reproducible on a 2023-07-15 Nightly build on macOS 12.
Verified as fixed on Firefox 118.0b2(20230829180158) and Nightly 119.0a1(20230830042643) on macOS 12.
Updated•29 days ago
|
Description
•