1416996 - setup builders to compile suite w/ stylo enabled

Status: RESOLVED WONTFIX

(SeaMonkey :: Release Engineering, enhancement)

Description

[Edmund Wong (:ewong)]

At this point, we do not have stylo (and thus webrender) enabled on
all our builds.  This means we don't know what will happen if we
do. 

I'd like to have a set of builders w/ stylo enabled and using
just comm-central.

Comment 1

[Edmund Wong (:ewong)]

Attachment: [mozconfigs] additional nightly-stylo mozconfigs

Comment 2

[Edmund Wong (:ewong)]

Attachment: [mozconfigs] nightly-stylo mozconfigs.

rationale for macosx64's mozconfig.  

We don't do cross-compile and since we don't need the disable stylo,
we might as well just directly use local-mozconfig.common

Comment 3

[Edmund Wong (:ewong)]

Attachment: [configs] enable stylo builds for c-c only

Comment 4

[Frank-Rainer Grahl (:frg)]

Comment on attachment 8928365 [details] [diff] [review]
[mozconfigs] nightly-stylo mozconfigs.

> +ac_add_options --enable-webrender

I think this is the default now. Could you check.

r+ with this checked.

Keep in mind that we plan to do cross-compiles. If i find some time I will start with the configs soon. probably Nightly only first.

Comment 5

[Frank-Rainer Grahl (:frg)]

Comment on attachment 8928368 [details] [diff] [review]
[configs] enable stylo builds for c-c only

> +        if platform in BRANCHES[branch]['platforms']

Missing/accidentally removed : I think.

r+ with nit fixed.

Comment 6

[Edmund Wong (:ewong)]

Attachment: [configs] fix nits

Comment 7

[Edmund Wong (:ewong)]

(In reply to Frank-Rainer Grahl (:frg) from comment #4)
> Comment on attachment 8928365 [details] [diff] [review]
> [mozconfigs] nightly-stylo mozconfigs.
> 
> > +ac_add_options --enable-webrender
> 
> I think this is the default now. Could you check.
> 
> r+ with this checked.
> 
> Keep in mind that we plan to do cross-compiles. If i find some time I will
> start with the configs soon. probably Nightly only first.

from https://hg.mozilla.org/mozilla-central/file/tip/toolkit/moz.configure#l850,

I suppose it means it is enabled by default.

Comment 8

[Edmund Wong (:ewong)]

Attachment: [mozconfigs] nightly-stylo mozconfigs (v2) [checked-in]

since webrender is enabled by default,  no need for --enable-webrender..
(from https://hg.mozilla.org/mozilla-central/file/tip/toolkit/moz.configure#l850)
though I don't see it being disabled (aside from --disable-webrender).

Comment 9

[Frank-Rainer Grahl (:frg)]

Comment on attachment 8928847 [details] [diff] [review]
[mozconfigs] nightly-stylo mozconfigs (v2) [checked-in]

r+

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/99accbe79a6d
Re-enable stylo/webrender building in suite using separate stylo mozconfigs. r=frg

Comment 11

[Edmund Wong (:ewong)]

Attachment: [configs] moved if line to within for loop

Comment 12

[Edmund Wong (:ewong)]

Attachment: [configs] fixed configs to enable stylo for linux* and linux-debug only [checked-in]

Just going to do the stylo builds for linux, linux64 and linux-debug only.
We don't have enough osx64 or wiin32 machines to even worth bothering
with stylo builds.

Comment 13

[Frank-Rainer Grahl (:frg)]

Comment on attachment 8952643 [details] [diff] [review]
[configs] fixed configs to enable stylo for linux* and linux-debug only [checked-in]

NIT: 2 trailing blanks in comments.

I see only a nightly-stylo in the suite linux32 configs. Do we need a debug-stylo too?

r+ with NITs fixed and question answered.

Comment 14

[Edmund Wong (:ewong)]

(In reply to Frank-Rainer Grahl (:frg) from comment #13)
> Comment on attachment 8952643 [details] [diff] [review]
> [configs] fixed configs to enable stylo for linux* and linux-debug only
> 
> NIT: 2 trailing blanks in comments.
> 
> I see only a nightly-stylo in the suite linux32 configs. Do we need a
> debug-stylo too?
> 
> r+ with NITs fixed and question answered.

I'll fix the nit.

As for linux-debug,  it's covered.  

+for plat in PLATFORMS_TO_BUILD_STYLO:
+    if plat.endswith('-debug'):
+        plat_with_stylo = "%s-stylo-%s" % tuple(plat.split("-"))
+    else:
+        plat_with_stylo = '%s-stylo' % plat
+    PLATFORM_VARS[plat_with_stylo] = deepcopy(PLATFORM_VARS[plat])

I'm opting to do a

Comment 15

[Edmund Wong (:ewong)]

(In reply to Edmund Wong (:ewong) from comment #14)
> (In reply to Frank-Rainer Grahl (:frg) from comment #13)
> > Comment on attachment 8952643 [details] [diff] [review]
> > [configs] fixed configs to enable stylo for linux* and linux-debug only
> > 
> > NIT: 2 trailing blanks in comments.
> > 
> > I see only a nightly-stylo in the suite linux32 configs. Do we need a
> > debug-stylo too?
> > 
> > r+ with NITs fixed and question answered.
> 
> I'll fix the nit.
> 
> As for linux-debug,  it's covered.  
> 
> +for plat in PLATFORMS_TO_BUILD_STYLO:
> +    if plat.endswith('-debug'):
> +        plat_with_stylo = "%s-stylo-%s" % tuple(plat.split("-"))
> +    else:
> +        plat_with_stylo = '%s-stylo' % plat
> +    PLATFORM_VARS[plat_with_stylo] = deepcopy(PLATFORM_VARS[plat])
> 
> I'm opting to do a

I'm opting to do linux-stylo-debug instead of linux-debug-stylo as
having stylo at the end of -debug will require some additional changes
as some of our buildbot code checks for '-debug' at the end.

Comment 16

[Edmund Wong (:ewong)]

*oh* sigh.  reading fail.

Yes.  We do need a mozconfig for debug-stylo.

Comment 17

[Edmund Wong (:ewong)]

Attachment: [mozconfigs] add debug-stylo mozconfig.

Comment 18

[Edmund Wong (:ewong)]

Attachment: [mozconfigs] add debug-stylo mozconfig

Comment 19

[Edmund Wong (:ewong)]

Attachment: [mozconfigs] add debug-stylo mozconfig [checked-in]

this time, w/ username

Comment 20

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/228f05fcbd6c
Add debug-stylo mozconfigs r=frg

Comment 21

[Edmund Wong (:ewong)]

Comment on attachment 8952643 [details] [diff] [review]
[configs] fixed configs to enable stylo for linux* and linux-debug only [checked-in]

Pushed to buildbot-configs:
https://hg.mozilla.org/build/buildbot-config/rev/80677b469cfbb49e47fee4abe342e7f7701cce36

Comment 22

[Edmund Wong (:ewong)]

Attachment: [configs] tinderbox builds should be separated

just realized that any future uploads  will be uploaded to the same
dir i.e. comm-central-trunk  and since the uploaded files are the same
(we don't differentiate stylobuilds and normal builds), this could be
problematic with people download tinderbox builds and expecting normal ones.

Comment 23

[Frank-Rainer Grahl (:frg)]

Comment on attachment 8952976 [details] [diff] [review]
[configs] tinderbox builds should be separated

r+ assuming ',' at the end of the list is valid.

> stylo,})

Comment 24

[Edmund Wong (:ewong)]

Attachment: [configs] tinderbox builds should be separated [checked-in]

,} valid python, but not PEP8 valid python. :P

fixed.

Comment 25

[Edmund Wong (:ewong)]

Comment on attachment 8952979 [details] [diff] [review]
[configs] tinderbox builds should be separated [checked-in]

Pushed to buildbot-configs:
remote:   https://hg.mozilla.org/build/buildbot-configs/rev/39116a4b1f1fb9352f35cb5683aa8e8b7010f893

Comment 26

[Edmund Wong (:ewong)]

ok.. the selected builders are up.

keeping this bug opened until all platforms are included.

Comment 27

[Edmund Wong (:ewong)]

Attachment: [mozconfigs] do not use build/mozconfig.stylo

reason being build/mozconfig.stylo disables stylo

Comment 28

[Frank-Rainer Grahl (:frg)]

Comment on attachment 8953063 [details] [diff] [review]
[mozconfigs] do not use build/mozconfig.stylo

r+ 

user missing in the patch :)

Comment 29

[Edmund Wong (:ewong)]

Attachment: [mozconfigs] fix with name

Comment 30

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/552fd5ab0b44
Do not use mozconfig.stylo as it disables stylo builds for linux-stylo r=frg

Comment 31

[Edmund Wong (:ewong)]

Pushed to buildbot-configs:
https://hg.mozilla.org/build/buildbot-configs/rev/5435cfaef33b

Just enable building stylo on linux only.

Comment 32

[Edmund Wong (:ewong)]

Thanks to bug 1447611, these extra stylo builders are no longer necessary.  Stylo is now
built on by default and --disable-stylo has been removed.

Reverting all these changes.

Comment 33

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/e48b29d0f2bf
Backout --disable-stylo from mozconfigs. r=bustagefix