1418669 - Clicking the bookmark star does not bookmark the page; star does not turn blue

Status: RESOLVED INVALID

(Firefox :: Bookmarks & History, defect)

Description

[lerissa.patrick]

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:57.0) Gecko/20100101 Firefox/57.0
Build ID: 20171112125346

Steps to reproduce:

Clicked Bookmark star button to bookmark a page.


Actual results:

On rollover: Legend "Show your bookmarks" appeared. 

On click: Dropdown bookmarks menu appeared. 


Expected results:

1. Star should turn blue.
2. "Page bookmarked" box should appear, with options for naming and filing the new bookmark.

Comment 1

[lerissa.patrick]

I'm sorry: I was using the wrong star button - didn't notice that old one has moved to the left and the new one is not for bookmarking. Please delete this bug report.

Comment 2

[Mark Banner (:standard8)]

Thank you for updating us. I'll mark this as invalid.

Comment 3

[Mauro Di Blasi]

I have this same bug with Firefox 64, Mac.

- most of the times the star works;
- under unclear circumstances the star simply stops working: you click it but nothing happens;
- if you click the library icon and try to do the same from the bookmarks submenu, ANY website you visit is marked as it was bookmarked (even with sites you NEVER bookmarked). After a while this strange blue icon turns white (but not clickable) again;
- if you restart the browser, it starts as the issue was solved, but it isn't;

Comment 4

[Mauro Di Blasi]

Mozilla/5.0 (Macintosh; Intel Mac OS X 10.14; rv:64.0) Gecko/20100101 Firefox/64.0

Comment 5

[Marco Bonardo [:mak]]

(In reply to Mauro Di Blasi from comment #3)
> I have this same bug with Firefox 64, Mac.
> 
> - most of the times the star works;
> - under unclear circumstances the star simply stops working: you click it
> but nothing happens;
> - if you click the library icon and try to do the same from the bookmarks
> submenu, ANY website you visit is marked as it was bookmarked (even with
> sites you NEVER bookmarked). After a while this strange blue icon turns
> white (but not clickable) again;
> - if you restart the browser, it starts as the issue was solved, but it
> isn't;

This is 1 year old bug, and it ended up being invalid because the user was trying to use the menu button as the star button (both have a star on it). You should file a new bug.
But first, you should check your database is sane (from about:support you can run the Places Database integrity check) and that you are not using some third party software that may be accessing our database in background, I heard some Mac software like Cookies tend to do that.

Comment 6

[Mauro Di Blasi]

Hi Marco, thanks for your kind reply. I'll file a new bug.

Anyway, the db is ok and I have no Cookie software installed (I also use very few extensions, only Lightbeam and Mozilla Laboratory).

This is my db:
> Task: checkIntegrity
+ The places.sqlite database is sane
+ The favicons.sqlite database is sane
> Task: invalidateCaches
+ The caches have been invalidated
> Task: checkCoherence
+ The database is coherent
> Task: expire
+ Database cleaned up
> Task: originFrecencyStats
+ Recalculated origin frecency stats
> Task: vacuum
+ Initial database size is 76800KiB
+ The database has been vacuumed
+ Final database size is 66560KiB
> Task: stats
+ Places.sqlite size is 66560KiB
+ Favicons.sqlite size is 74592KiB
+ pragma_user_version is 52
+ pragma_page_size is 32768
+ pragma_cache_size is -2048
+ pragma_journal_mode is wal
+ pragma_synchronous is 1
+ History can store a maximum of 144565 unique pages
+ Table moz_places has 136330 records
+ Table moz_historyvisits has 152792 records
+ Table moz_inputhistory has 98 records
+ Table moz_hosts has 0 records
+ Table moz_bookmarks has 7546 records
+ Table moz_keywords has 0 records
+ Table sqlite_sequence has 0 records
+ Table moz_anno_attributes has 6 records
+ Table moz_annos has 4297 records
+ Table moz_items_annos has 5008 records
+ Table sqlite_stat1 has 18 records
+ Table moz_bookmarks_deleted has 0 records
+ Table moz_meta has 7 records
+ Table moz_origins has 7618 records
+ Index sqlite_autoindex_moz_inputhistory_1
+ Index sqlite_autoindex_moz_hosts_1
+ Index sqlite_autoindex_moz_keywords_1
+ Index sqlite_autoindex_moz_anno_attributes_1
+ Index sqlite_autoindex_moz_bookmarks_deleted_1
+ Index sqlite_autoindex_moz_origins_1
+ Index moz_places_hostindex
+ Index moz_places_visitcount
+ Index moz_places_frecencyindex
+ Index moz_places_lastvisitdateindex
+ Index moz_historyvisits_placedateindex
+ Index moz_historyvisits_fromindex
+ Index moz_historyvisits_dateindex
+ Index moz_bookmarks_itemindex
+ Index moz_bookmarks_parentindex
+ Index moz_bookmarks_itemlastmodifiedindex
+ Index moz_places_url_hashindex
+ Index moz_places_guid_uniqueindex
+ Index moz_bookmarks_guid_uniqueindex
+ Index moz_keywords_placepostdata_uniqueindex
+ Index moz_annos_placeattributeindex
+ Index moz_items_annos_itemattributeindex
+ Index moz_bookmarks_dateaddedindex
+ Index moz_places_originidindex
> Task: _refreshUI