1420039 - GroupRuleRuleList::GetParentObject should return a ServoStyleSheet too

Status: RESOLVED INVALID

(Core :: CSS Parsing and Computation, enhancement)

Comment 1

[Cameron McCormack (:heycam)]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=849f2dbea1e2bed49a67b086224e467586b86eb9

Comment 2

[Cameron McCormack (:heycam)]

Attachment: Bug 1420039 - Return a ServoStyleSheet from GroupRuleRuleList::GetParentObject when the rule is Servo-backed.

Review commit: https://reviewboard.mozilla.org/r/202316/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/202316/

Comment 3

[Code Review Bot [:reviewbot]]

Comment on attachment 8931214 [details]
Bug 1420039 - Return a ServoStyleSheet from GroupRuleRuleList::GetParentObject when the rule is Servo-backed.

https://reviewboard.mozilla.org/r/202316/#review207682


C/C++ static analysis found 1 defect in this patch.

You can run this analysis locally with: `./mach static-analysis check path/to/file.cpp`


::: layout/style/GroupRule.cpp:35
(Diff revision 1)
>  class GroupRuleRuleList final : public dom::CSSRuleList
>  {
>  public:
>    explicit GroupRuleRuleList(GroupRule *aGroupRule);
>  
> -  virtual CSSStyleSheet* GetParentObject() override;
> +  virtual StyleSheet* GetParentObject() override;

Warning: 'virtual' is redundant since the function is already declared 'override' [clang-tidy: modernize-use-override]

Comment 4

[Cameron McCormack (:heycam)]

Comment on attachment 8931214 [details]
Bug 1420039 - Return a ServoStyleSheet from GroupRuleRuleList::GetParentObject when the rule is Servo-backed.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/202316/diff/1-2/

Comment 5

[Xidorn Quan [:xidorn] UTC+11]

I don't understand why this change is necessary. GroupRuleRuleList is only used inside GeckoGroupRuleRules, and thus it should never have a Servo style sheet. Why does it need to return StyleSheet rather than the more specific CSSStyleSheet?

Comment 6

[Xidorn Quan [:xidorn] UTC+11]

Comment on attachment 8931214 [details]
Bug 1420039 - Return a ServoStyleSheet from GroupRuleRuleList::GetParentObject when the rule is Servo-backed.

https://reviewboard.mozilla.org/r/202316/#review207846

Comment 7

[Cameron McCormack (:heycam)]

Oh, my mistake.