Closed
Bug 1420853
Opened 7 years ago
Closed 6 years ago
Ensure only fields valid for the given country are saved
Categories
(Toolkit :: Form Autofill, defect, P1)
Toolkit
Form Autofill
Tracking
()
VERIFIED
FIXED
mozilla64
| Tracking | Status | |
|---|---|---|
| firefox64 | --- | verified |
People
(Reporter: scottwu, Assigned: jaws)
References
(Blocks 2 open bugs)
Details
(Whiteboard: [webpayments] [form autofill:V2])
Attachments
(1 file, 1 obsolete file)
For countries like Germany, which doesn't fill address-level1 (province), there's a chance we'd inadvertently populate address-level1 if the field is not empty. STR: 1. Set country to US 2. Fill the State field 3. Change country to Germany 4. Save address The hidden address-level1 field (previously State) probably shouldn't be saved as part of a German address.
|
||
Updated•7 years ago
|
Blocks: DE-CA-address-support-meta
|
Reporter | |
Updated•7 years ago
|
Whiteboard: [form autofill:V2]
|
|
Reporter | |
Updated•7 years ago
|
Assignee: nobody → scwwu
| Comment hidden (mozreview-request) |
|
|
||
Comment 2•6 years ago
|
||
| mozreview-review | ||
Comment on attachment 8942597 [details] Bug 1420853 - Ensure only fields valid for the given country are saved. https://reviewboard.mozilla.org/r/212862/#review219138
Attachment #8942597 -
Flags: review?(lchang) → review+
|
||
Updated•6 years ago
|
Whiteboard: [form autofill:V2] → [form autofill:V2] [webpayments]
|
|
||
Updated•6 years ago
|
Priority: -- → P3
|
||
Updated•6 years ago
|
Status: NEW → ASSIGNED
Priority: P3 → P1
Whiteboard: [form autofill:V2] [webpayments] → [form autofill:V2] [webpayments-reserve]
|
||
Comment 3•6 years ago
|
||
Another issue worth to mention that could be handled here: Editing an already saved address from DE to US populate the state field automatically STR: 1. Go to "https://rsolomakhin.github.io/pr/single/" and click on "Buy" button. 2. Edit an already saved shipping address country from US to DE. 3. Edit the same shipping address and change the country again from DE to US.
|
|
||
Updated•6 years ago
|
Assignee: scottcwwu → nobody
Status: ASSIGNED → NEW
|
|
||
Updated•6 years ago
|
Priority: P1 → P3
Whiteboard: [form autofill:V2] [webpayments-reserve] → [webpayments-reserve] [form autofill:V2]
|
|
||
Updated•6 years ago
|
Flags: qe-verify?
Priority: P3 → P2
Whiteboard: [webpayments-reserve] [form autofill:V2] → [webpayments] [form autofill:V2]
|
|
||
Updated•6 years ago
|
Flags: qe-verify? → qe-verify+
QA Contact: hani.yacoub
|
Assignee | |
Updated•6 years ago
|
Assignee: nobody → jaws
Status: NEW → ASSIGNED
|
|
||
Updated•6 years ago
|
Priority: P2 → P1
|
|
Assignee | |
Comment 4•6 years ago
|
||
This patch is a completion of the work done by Scott Wu.
|
|
||
Updated•6 years ago
|
Attachment #8942597 -
Flags: review?(steveck324)
|
|
||
Updated•6 years ago
|
Attachment #8942597 -
Attachment is obsolete: true
Pushed by jwein@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/95fe4f9c3203 Ensure only fields valid for the given country are saved. r=MattN
|
||
Comment 6•6 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/95fe4f9c3203
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
status-firefox64:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla64
|
|
||
Comment 7•6 years ago
|
||
Verified as fixed on Firefox Nightly 64.0a1 (2018-10-22) on Windows 10 x 64, Windows 7 x32, Mac OS X 10.13 and on Ubuntu 16.04 x64.
You need to log in
before you can comment on or make changes to this bug.
Description
•