Closed
Bug 1420893
Opened 7 years ago
Closed 5 years ago
Remove mediaconduit_unittests
Categories
(Core :: WebRTC: Audio/Video, enhancement, P3)
Tracking
()
RESOLVED
FIXED
mozilla72
| Tracking | Status | |
|---|---|---|
| firefox72 | --- | fixed |
People
(Reporter: dminor, Assigned: dminor)
References
(Depends on 1 open bug)
Details
Attachments
(1 file)
Once the new tests for Bug 1404994 are written we should remove the old mediaconduit_unittests. Those tests are flaky and difficult to work with because they rely upon RTP flow (and sleeping for results). The mocks provided by the new conduit tests make it easier to test the interfaces between the signaling layer and the codecs, and we have mochitests to provide integration testing.
|
||
Updated•7 years ago
|
Rank: 28
Priority: -- → P3
|
Assignee | |
Comment 2•5 years ago
|
||
Both of the test cases in mediaconduit_unittests are disabled anyway, so we might as well go ahead and remove the test now.
|
|
Assignee | |
Comment 3•5 years ago
|
||
I misread, only the audio unit test is disabled, but I still think we're safe to remove this, we have videoconduit_unittests to cover the VideoConduit anyway.
Assignee: nobody → dminor
Status: NEW → ASSIGNED
|
|
Assignee | |
Comment 4•5 years ago
|
||
Pushed by dminor@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/63f3e109f02b Remove mediaconduit_unittests; r=pehrsons
|
||
Comment 6•5 years ago
|
||
| bugherder | ||
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
status-firefox72:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla72
|
||
Comment 7•5 years ago
|
||
| bugherder landing | ||
You need to log in
before you can comment on or make changes to this bug.
Description
•