1422560 - Crash under [@ mozilla::dom::StopGamepadMonitoring()]

Status: RESOLVED WONTFIX

(Core :: DOM: Device Interfaces, defect, P2)

Description

[Justin Dolske [:Dolske]]

I get a 100% reproducible crash on Nightly/macOS when loading https://classicreload.com/a8b_mule.html with a USB joystick plugged in. I think it also crashed once without a joystick plugged in, but I'm not sure.

e.g. bp-aec86eb5-bab3-46dc-a753-a7ada0171203

0 pthread_mutex_lock
1 -[NSMutableArray sortUsingComparator:]
2 mozilla::dom::StopGamepadMonitoring()
3 mozilla::dom::MaybeStopGamepadMonitoring()
4 mozilla::dom::GamepadEventChannelParent::ActorDestroy()

Sorta sounds like bug 1347519 was trying to fix this (similar crash stack there), so maybe this is a dupe?

Comment 1

[Justin Dolske [:Dolske]]

I guess I also see bug 1382176, but that says not reproducible.

Comment 2

[Hsin-Yi Tsai (she/her) [:hsinyi]]

Hi Michael, are you the right person to take a look at this crash and comment 0 or to point me to the right person?

Comment 3

[Michael Leu[:Lenzak](UTC+8)]

I can reproduce this crash, it is the first time I encounter it in person.

Hi Justin, can you test the patch in bug 1397194 ?

This patch utilizes gecko's nsITimer instead of macos' native eventloop.

Comment 4

[Justin Dolske [:Dolske]]

I haven't had time to build and test this. Maybe someone can point me at a try build?

Comment 5

[Kyle Machulis [:qdot] [:kmachulis] (INACTIVE)]

The patch mentioned was already landed, so anything on nightly should work.

Comment 6

[Sylvestre Ledru [:Sylvestre]]

Closing because no crash reported since 12 weeks.

Comment 7

[Sylvestre Ledru [:Sylvestre]]

Closing because no crash reported since 12 weeks.