1424100 - Fix instructions font-color in synced tabs sidebar since low contrast and different from the others

Status: VERIFIED FIXED

(Firefox :: Theme, defect, P3)

Description

[magicp]

Attachment: instructions-font-color-on-windows.png

Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:59.0) Gecko/20100101 Firefox/59.0 ID:20171207100053

Steps to reproduce:
1. Launch the latest Nightly on Windows
2. Show the Synced tabs sidebar with sign out
3. Open Library button > Synced Tabs
4. Compare font color of instructions "Sign in to..."

Actual Results:
In synced tabs sidebar, instructions font-color is low contrast and different from panelview's one.

Expected Results:
Use same font color with panelview's one.

Regression range:
https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=126be0de348b73b16f5eda1982c61baa638175ce&tochange=4695551e0df164e6f6c0513b2b992653cd97201a

Comment 1

[Dão Gottwald [:dao]]

eoger, could you please look into this?

Comment 2

[Carol Ng [:cng]]

Attachment: Bug 1424100 - Make sidebar text color consistent with panel UI

Review commit: https://reviewboard.mozilla.org/r/246212/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/246212/

Comment 3

[Edouard Oger [:eoger]]

Comment on attachment 8980042 [details]
Bug 1424100 - Make sidebar text color consistent with panel UI

https://reviewboard.mozilla.org/r/246212/#review252314

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/8416a4f99552
Make panel instructions color consistent with sidebar. r=eoger

Comment 5

[Dão Gottwald [:dao]]

Comment on attachment 8980042 [details]
Bug 1424100 - Make sidebar text color consistent with panel UI

Alas, this is wrong. It won't work with dark themes such as High Contrast themes on Windows. What you'll probably want to do instead is revert the sidebar to use GrayText again.

Comment 6

[Eliza Balazs [:ebalazs_]]

https://hg.mozilla.org/mozilla-central/rev/8416a4f99552

Comment 7

[Dão Gottwald [:dao]]

Backed out:
https://hg.mozilla.org/integration/mozilla-inbound/rev/78c400d841f513528536ac3fded97bc31affc4fc

Comment 8

[Carol Ng [:cng]]

Comment on attachment 8980042 [details]
Bug 1424100 - Make sidebar text color consistent with panel UI

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/246212/diff/1-2/

Comment 9

[Dão Gottwald [:dao]]

Comment on attachment 8980042 [details]
Bug 1424100 - Make sidebar text color consistent with panel UI

https://reviewboard.mozilla.org/r/246212/#review252548

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/40eeaf5f1230
Make sidebar text color consistent with panel UI r=dao,eoger

Comment 11

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

Backed out changeset 8416a4f99552 (bug 1424100) 
https://hg.mozilla.org/mozilla-central/rev/78c400d841f5

Comment 12

[Cristian Brindusan [:cbrindusan]]

https://hg.mozilla.org/mozilla-central/rev/40eeaf5f1230

Comment 13

[Ryan VanderMeulen [:RyanVM]]

Looks like a trivial patch, please request Beta approval on it when you get a chance.

Comment 14

[Carol Ng [:cng]]

Comment on attachment 8980042 [details]
Bug 1424100 - Make sidebar text color consistent with panel UI

Approval Request Comment
[Feature/Bug causing the regression]: Bug 1419838
[User impact if declined]: Text on synced tabs sidebar would be illegible for High Contrast themes on Windows
[Is this code covered by automated tests?]: No
[Has the fix been verified in Nightly?]: No
[Needs manual test from QE? If yes, steps to reproduce]: No
[List of other uplifts needed for the feature/fix]: No
[Is the change risky?]: No
[Why is the change risky/not risky?]: No, minor CSS change
[String changes made/needed]: No

Comment 15

[Ryan VanderMeulen [:RyanVM]]

Comment on attachment 8980042 [details]
Bug 1424100 - Make sidebar text color consistent with panel UI

Small fix to improve panel styling. Approved for 61.0b9.

Comment 16

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-beta/rev/e796c301b3ba

Comment 17

[Mohammad Maruf Rahman]

I have reproduced this bug with Nightly 59.0a1 (2017-12-07) on Windows 10, 64 Bit!
This bug's fox is verified with latest Beta and latest Nightly!

Build ID 	20180607135512
User Agent 	Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:61.0) Gecko/20100101 Firefox/61.0


Build ID 	20180610220159
User Agent 	Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:62.0) Gecko/20100101 Firefox/62.0

Comment 18

[Maria Berlinger [:mberlinger], Services QA]

I have managed to reproduce this bug on an affected Nightly build 59.0a1 (2017-12-07), using the STR from comment 0. 

This is verified fixed on latest Beta 62.0b5 (20180702164905) and Release 61.0 (20180621125625) on the following OSes: Windows 10 x64, Ubuntu 16.04 x64 and Mac X OS 10.11.6.