1424974 - [e10s] fix regression at Bug 1423810

Status: RESOLVED FIXED

(Core :: Widget: Gtk, enhancement)

Description

[Martin Stránský [:stransky] (ni? me)]

+++ This bug was initially created as a clone of Bug #1423810 +++

We need to provide better fix for Bug 1423810 and enable titlebar rendering in CSD mode.

Comment 1

[Martin Stránský [:stransky] (ni? me)]

It's reproducible with e10s enabled only.

Comment 2

[Martin Stránský [:stransky] (ni? me)]

Looks related to Bug 1196494 - property_notify_event_cb() is not called for mShell when it has child mContainer window.

Comment 3

[Martin Stránský [:stransky] (ni? me)]

Attachment: patch

WIP but functional patch, storing here for further work.

Comment 4

[Martin Stránský [:stransky] (ni? me)]

Attachment: Bug 1424974 - Honor mShell as top-level window,

When drawing to mContainer we still need to honor mShell as top-level window.
It means we have to listen property-notify-event there (as it's window specific),
get _NET_FRAME_EXTENTS here and use at nsWindow::SetWindowClass().

Review commit: https://reviewboard.mozilla.org/r/208642/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/208642/

Comment 5

[Jan Horak [:jhorak]]

Comment on attachment 8937943 [details]
Bug 1424974 - Honor mShell as top-level window,

https://reviewboard.mozilla.org/r/208642/#review214794

::: widget/gtk/nsWindow.cpp:3897
(Diff revision 1)
>          break;
>      }
>  
>      // label the drawing window with this object so we can find our way home
>      g_object_set_data(G_OBJECT(mGdkWindow), "nsWindow", this);
> +    if (drawToContainer) {

Please add brief description why do you need to add nsWindow reference to the mShell.

Comment 6

[Martin Stránský [:stransky] (ni? me)]

Comment on attachment 8937943 [details]
Bug 1424974 - Honor mShell as top-level window,

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/208642/diff/1-2/

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/872897434908
Honor mShell as top-level window, r=jhorak

Comment 8

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/872897434908