142510 - Need access to OnShowContextMenu()

Status: RESOLVED WONTFIX

(Core Graveyard :: Embedding: GTK Widget, enhancement)

Description

[Guy Alfandary]

EmbedWindow needs to implement nsIContextMenuListener
and forward a corresponding signal to the embedded widget.

Comment 1

[Christian Persch (GNOME) (away; not receiving bug mail)]

Attachment: proposed implementation

This patch implements a "dom_context_menu" signal on GtkMozEmbed.

Comment 2

[Christian Persch (GNOME) (away; not receiving bug mail)]

Comment on attachment 143136 [details] [diff] [review]
proposed implementation

Asking for r/sr

Comment 3

[Brian Ryner (not reading)]

Comment on attachment 143136 [details] [diff] [review]
proposed implementation

Looks fine given how the other event listeners are implemented.

However, I'm a bit worried about event cancellation being implemented by
returning something other than NS_OK from the DOM event listener.  That doesn't
really accomplish much afaik.  It seems like you'd want a boolean which would
then cause event->PreventDefault() to be called if it is set by the signal
callback.  I'm ok with cleaning this up later though.

Comment 4

[Christopher Blizzard (:blizzard)]

Comment on attachment 143136 [details] [diff] [review]
proposed implementation

I hate to be a jerk but I would rather get the event handling right.  We have
enough problems with event handling as it is.

Comment 5

[Christian Persch (GNOME) (away; not receiving bug mail)]

*** Bug 206713 has been marked as a duplicate of this bug. ***

Comment 6

[Sylvestre Ledru [:Sylvestre]]

Embedding: GTK Widget isn't a thing, closing.